content/browser/accessibility/accessibility_ui.cc - Issue 642313003: [C++11 Allowed Features] Declares a type-safe null pointer converting from NULL to nullptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/accessibility_ui.cc

Issue 642313003: [C++11 Allowed Features] Declares a type-safe null pointer converting from NULL to nullptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Including id in the AUTHORS file. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/accessibility/accessibility_mode_browsertest.cc ('K') | « content/browser/accessibility/accessibility_tree_formatter_mac.mm ('k') | content/browser/accessibility/accessibility_win_browsertest.cc » ('j') | content/browser/accessibility/accessibility_win_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/accessibility_ui.cc

diff --git a/content/browser/accessibility/accessibility_ui.cc b/content/browser/accessibility/accessibility_ui.cc

index a8a5d97ad3ef62bb594ccc8cc7ea395fcb373f80..e80edfcbe3566e8518349bcc23096021b2c3d6a2 100644

--- a/content/browser/accessibility/accessibility_ui.cc

+++ b/content/browser/accessibility/accessibility_ui.cc

@@ -78,7 +78,7 @@ base::DictionaryValue* BuildTargetDescriptor(RenderViewHost* rvh) {

title = base::UTF16ToUTF8(web_contents->GetTitle());

NavigationController& controller = web_contents->GetController();

NavigationEntry* entry = controller.GetVisibleEntry();

- if (entry != NULL && entry->GetURL().is_valid())

+ if (entry != nullptr && entry->GetURL().is_valid())

favicon_url = entry->GetFavicon().url;

}