Use C++11 range-based loop in core/frame

Use C++11 range-based loop in core/frame

Improves code readability

BUG=none
TEST=no layout test failures

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183816

[riju_, 2014-10-16 08:49:15]

rijubrata.bhaumik@intel.com changed reviewers:
+ mkwst@chromium.org

[riju_, 2014-10-16 08:49:16]

PTAL

[Mike West, 2014-10-16 09:09:40]

LGTM.

https://codereview.chromium.org/642293004/diff/20001/Source/core/frame/FrameV...
File Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/642293004/diff/20001/Source/core/frame/FrameV...
Source/core/frame/FrameView.cpp:2295: for (const auto& it : *m_scrollableAreas)
{
s/it/scrollableArea/, and then just change the references below to drop the
pointer deref.

https://codereview.chromium.org/642293004/diff/20001/Source/core/frame/FrameV...
Source/core/frame/FrameView.cpp:2421: for (const auto& current : *viewChildren)
{
s/current/child/

https://codereview.chromium.org/642293004/diff/20001/Source/core/frame/FrameV...
Source/core/frame/FrameView.cpp:3814: for (const auto& current : m_children)
s/current/child/

https://codereview.chromium.org/642293004/diff/20001/Source/core/frame/FrameV...
Source/core/frame/FrameView.cpp:4165: for (const auto& it : m_children)
s/it/child/

[riju_, 2014-10-16 11:30:45]

Thanks

https://codereview.chromium.org/642293004/diff/20001/Source/core/frame/FrameV...
File Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/642293004/diff/20001/Source/core/frame/FrameV...
Source/core/frame/FrameView.cpp:2295: for (const auto& it : *m_scrollableAreas)
{
On 2014/10/16 09:09:40, Mike West wrote:
> s/it/scrollableArea/, and then just change the references below to drop the
> pointer deref.

Done.

https://codereview.chromium.org/642293004/diff/20001/Source/core/frame/FrameV...
Source/core/frame/FrameView.cpp:2421: for (const auto& current : *viewChildren)
{
On 2014/10/16 09:09:39, Mike West wrote:
> s/current/child/

Done.

https://codereview.chromium.org/642293004/diff/20001/Source/core/frame/FrameV...
Source/core/frame/FrameView.cpp:3814: for (const auto& current : m_children)
On 2014/10/16 09:09:39, Mike West wrote:
> s/current/child/

Done.

https://codereview.chromium.org/642293004/diff/20001/Source/core/frame/FrameV...
Source/core/frame/FrameView.cpp:4165: for (const auto& it : m_children)
On 2014/10/16 09:09:40, Mike West wrote:
> s/it/child/

Done.

[riju_, 2014-10-16 12:10:04]

The CQ bit was checked by rijubrata.bhaumik@intel.com

[commit-bot: I haz the power, 2014-10-16 12:10:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/642293004/40001

[commit-bot: I haz the power, 2014-10-16 13:54:06]

Committed patchset #3 (id:40001) as 183816