Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 642263006: Remove trivially-true DEBUG_CHECKs in safe_sprintf.cc (Closed)

Created:
6 years, 2 months ago by Chris Masone
Modified:
6 years, 2 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org, Markus (顧孟勤)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove trivially-true DEBUG_CHECKs in safe_sprintf.cc There are some DEBUG_CHECKs here verifying that a size_t is >= 0. Since a size_t is unsigned, these are trivially true and with the default warning settings for CrOS builds, the warning generated here will cause a build failure. BUG=424334 TEST=ensure existing builds pass Committed: https://crrev.com/0adaa53ff018efd21bc30b37decf98a3df5d884e Cr-Commit-Position: refs/heads/master@{#300025}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M base/strings/safe_sprintf.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Chris Masone
On 2014/10/16 16:32:17, Chris Masone wrote: > mailto:cmasone@chromium.org changed reviewers: > + mailto:thestig@chromium.org Lei, do ...
6 years, 2 months ago (2014-10-16 16:33:20 UTC) #2
jln (very slow on Chromium)
lgtm
6 years, 2 months ago (2014-10-16 17:46:44 UTC) #3
jln (very slow on Chromium)
Lei: for some reason I'm not in that OWNERS file, do you mind approving this ...
6 years, 2 months ago (2014-10-16 17:48:39 UTC) #4
Lei Zhang
lgtm
6 years, 2 months ago (2014-10-16 21:12:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642263006/1
6 years, 2 months ago (2014-10-16 21:16:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/64260)
6 years, 2 months ago (2014-10-16 21:48:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642263006/1
6 years, 2 months ago (2014-10-16 22:17:22 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/64260)
6 years, 2 months ago (2014-10-16 22:39:48 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642263006/1
6 years, 2 months ago (2014-10-17 00:29:47 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 00:31:55 UTC) #19
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 00:32:42 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0adaa53ff018efd21bc30b37decf98a3df5d884e
Cr-Commit-Position: refs/heads/master@{#300025}

Powered by Google App Engine
This is Rietveld 408576698