Remove trivially-true DEBUG_CHECKs in safe_sprintf.cc

base/strings/safe_sprintf.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/safe_sprintf.h"
 
 #include <limits>
 
 #if !defined(NDEBUG)
 // In debug builds, we use RAW_CHECK() to print useful error messages, if
@@ skipping 158 matching lines @@
   }
 
   // Inserts |padding|-|len| bytes worth of padding into the |buffer_|.
   // |count_| will also be incremented by the number of bytes that were meant
   // to be emitted. The |pad| character is typically either a ' ' space
   // or a '0' zero, but other non-NUL values are legal.
   // Returns "false", iff the the |buffer_| filled up (i.e. |count_|
   // overflowed |size_|) at any time during padding.
   inline bool Pad(char pad, size_t padding, size_t len) {
     DEBUG_CHECK(pad);
-    DEBUG_CHECK(padding >= 0 && padding <= kSSizeMax);
-    DEBUG_CHECK(len >= 0);
+    DEBUG_CHECK(padding <= kSSizeMax);
     for (; padding > len; --padding) {
       if (!Out(pad)) {
         if (--padding) {
           IncrementCount(padding-len);
         }
         return false;
       }
     }
     return true;
   }
@@ skipping 85 matching lines @@
 
 
 bool Buffer::IToASCII(bool sign, bool upcase, int64_t i, int base,
                       char pad, size_t padding, const char* prefix) {
   // Sanity check for parameters. None of these should ever fail, but see
   // above for the rationale why we can't call CHECK().
   DEBUG_CHECK(base >= 2);
   DEBUG_CHECK(base <= 16);
   DEBUG_CHECK(!sign || base == 10);
   DEBUG_CHECK(pad == '0' || pad == ' ');
-  DEBUG_CHECK(padding >= 0);
   DEBUG_CHECK(padding <= kSSizeMax);
   DEBUG_CHECK(!(sign && prefix && *prefix));
 
   // Handle negative numbers, if the caller indicated that |i| should be
   // treated as a signed number; otherwise treat |i| as unsigned (even if the
   // MSB is set!)
   // Details are tricky, because of limited data-types, but equivalent pseudo-
   // code would look like:
   //   if (sign && i < 0)
   //     prefix = "-";
@@ skipping 381 matching lines @@
     DEBUG_CHECK(src[0] != '%' || src[1] == '%');
     if (src[0] == '%' && src[1] == '%') {
       ++src;
     }
   }
   return buffer.GetCount();
 }
 
 }  // namespace strings
 }  // namespace base