Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1614)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 642243005: Remove comments regarding deleted mojo_examlpes.gypi. (Closed)

Created:
6 years, 2 months ago by msw
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove comments regarding deleted mojo_examlpes.gypi. mojo_examlpes.gypi was removed in the following CL: https://codereview.chromium.org/647263005 BUG=423889 TEST=NONE R=jamesr@chromium.org Committed: https://crrev.com/8f0f2bcc40da1e7dad556eccecdbce6a55d2104f Cr-Commit-Position: refs/heads/master@{#300354}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M mojo/examples/apptest/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M mojo/examples/aura_demo/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/examples/bitmap_uploader/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/content_handler_demo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/demo_launcher/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/echo/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M mojo/examples/keyboard/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/examples/media_viewer/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/examples/nesting_app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/pepper_container_app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/png_viewer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/sample_app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/surfaces_app/BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
M mojo/examples/wget/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/window_manager/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/examples/wm_flow/BUILD.gn View 5 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
msw
Hey James, please take a look; thanks!
6 years, 2 months ago (2014-10-20 20:45:02 UTC) #1
jamesr
whoops, lgtm
6 years, 2 months ago (2014-10-20 21:08:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642243005/1
6 years, 2 months ago (2014-10-20 21:10:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 22:24:01 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 22:24:47 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8f0f2bcc40da1e7dad556eccecdbce6a55d2104f
Cr-Commit-Position: refs/heads/master@{#300354}

Powered by Google App Engine
This is Rietveld 408576698