Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 647263005: Remove gyp for mojo/examples (Closed)

Created:
6 years, 2 months ago by jamesr
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove gyp for mojo/examples These will be developed in GN only from now on. BUG=423889 Committed: https://crrev.com/e6844014eac73557c945ba32a32f52f9f5eea708 Cr-Commit-Position: refs/heads/master@{#299783}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -923 lines) Patch
M mojo/mojo.gyp View 3 chunks +0 lines, -27 lines 0 comments Download
D mojo/mojo_examples.gypi View 1 chunk +0 lines, -896 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jamesr
6 years, 2 months ago (2014-10-15 20:54:15 UTC) #2
sky
LGTM
6 years, 2 months ago (2014-10-15 21:12:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647263005/1
6 years, 2 months ago (2014-10-15 22:45:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 23:10:40 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 23:11:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6844014eac73557c945ba32a32f52f9f5eea708
Cr-Commit-Position: refs/heads/master@{#299783}

Powered by Google App Engine
This is Rietveld 408576698