Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 642203003: platform: fix build on SmartOS (Closed)

Created:
6 years, 2 months ago by indutny
Modified:
6 years, 2 months ago
CC:
danno, v8-dev
Base URL:
gh:v8/v8@master
Project:
v8
Visibility:
Public.

Description

platform: fix build on SmartOS With -std=g++0x, `signbit` is no longer a define, and is an actual function declared in C++-specific headers. Thus checking it's presence with ifdef will no longer work. Considering that g++0x implies newer compiler, there should not be the case where it won't be present anymore. BUG= R=bmeurer@chromium.org, danno Committed: https://code.google.com/p/v8/source/detail?r=24730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M src/base/platform/platform.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/base/platform/platform-solaris.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
indutny
6 years, 2 months ago (2014-10-17 20:19:54 UTC) #1
danno
Sven, could you please take a look?
6 years, 2 months ago (2014-10-20 08:46:54 UTC) #4
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-20 11:17:10 UTC) #6
Sven Panne
On 2014/10/20 11:17:10, Benedikt Meurer wrote: > lgtm Quick explanation: We had a short discussion, ...
6 years, 2 months ago (2014-10-20 11:22:08 UTC) #7
indutny
On 2014/10/20 11:22:08, Sven Panne wrote: > On 2014/10/20 11:17:10, Benedikt Meurer wrote: > > ...
6 years, 2 months ago (2014-10-20 11:24:21 UTC) #8
Benedikt Meurer
6 years, 2 months ago (2014-10-20 11:27:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24730 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698