Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: sync/internal_api/public/base/cancelation_signal_unittest.cc

Issue 642023004: Standardize usage of virtual/override/final in sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/public/base/cancelation_signal_unittest.cc
diff --git a/sync/internal_api/public/base/cancelation_signal_unittest.cc b/sync/internal_api/public/base/cancelation_signal_unittest.cc
index e8b375dab6b992af7121eab43c273e7d2658afa1..58a35cc2eaa82b8dca21373636db87774290c942 100644
--- a/sync/internal_api/public/base/cancelation_signal_unittest.cc
+++ b/sync/internal_api/public/base/cancelation_signal_unittest.cc
@@ -18,7 +18,7 @@ namespace syncer {
class BlockingTask : public CancelationObserver {
public:
BlockingTask(CancelationSignal* cancel_signal);
- virtual ~BlockingTask();
+ ~BlockingTask() override;
// Starts the |exec_thread_| and uses it to execute DoRun().
void RunAsync(base::WaitableEvent* task_start_signal,
@@ -33,7 +33,7 @@ class BlockingTask : public CancelationObserver {
// Implementation of CancelationObserver.
// Wakes up the thread blocked in Run().
- virtual void OnSignalReceived() override;
+ void OnSignalReceived() override;
// Checks if we ever did successfully start waiting for |event_|. Be careful
// with this. The flag itself is thread-unsafe, and the event that flips it
@@ -150,7 +150,7 @@ bool CancelationSignalTest::VerifyTaskNotStarted() {
}
class FakeCancelationObserver : public CancelationObserver {
- virtual void OnSignalReceived() override { }
+ void OnSignalReceived() override {}
};
TEST(CancelationSignalTest_SingleThread, CheckFlags) {
« no previous file with comments | « sync/internal_api/public/attachments/on_disk_attachment_store.h ('k') | sync/internal_api/public/engine/model_safe_worker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698