google_apis/gcm/engine/heartbeat_manager.h - Issue 641943002: components: Introduce AlarmTimer class and use it for GCM heartbeat

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/heartbeat_manager.h

Issue 641943002: components: Introduce AlarmTimer class and use it for GCM heartbeat (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make some Timer variables protected to reduce duplication, clean up comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/gcm/engine/heartbeat_manager.h

diff --git a/google_apis/gcm/engine/heartbeat_manager.h b/google_apis/gcm/engine/heartbeat_manager.h

index 9266b98c8d4b21f02935002cd106dd314c27e40a..32a8e6b4e3205489fbfdf68bf5771d84f39ebcef 100644

--- a/google_apis/gcm/engine/heartbeat_manager.h

+++ b/google_apis/gcm/engine/heartbeat_manager.h

@@ -66,7 +66,7 @@ class GCM_EXPORT HeartbeatManager {

int server_interval_ms_;

// Timer for triggering heartbeats.

- base::Timer heartbeat_timer_;

+ base::Timer* heartbeat_timer_;

Daniel Erat 2014/10/15 15:04:22 please document the ownership of this pointer

Chirantan Ekbote 2014/10/16 21:26:38 Done.

// Callbacks for interacting with the the connection.

base::Closure send_heartbeat_callback_;

« base/timer/timer.h ('K') | « base/timer/timer.cc ('k') | google_apis/gcm/engine/heartbeat_manager.cc » ('j') | no next file with comments »