components: Introduce AlarmTimer class and use it for GCM heartbeat

google_apis/gcm/engine/heartbeat_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GOOGLE_APIS_GCM_ENGINE_HEARTBEAT_MANAGER_H_
 #define GOOGLE_APIS_GCM_ENGINE_HEARTBEAT_MANAGER_H_
 
 #include "base/callback.h"
 #include "base/logging.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 48 matching lines @@
   // Whether the last heartbeat ping sent has been acknowledged or not.
   bool waiting_for_ack_;
 
   // The current heartbeat interval.
   int heartbeat_interval_ms_;
   // The most recent server-provided heartbeat interval (0 if none has been
   // provided).
   int server_interval_ms_;
 
   // Timer for triggering heartbeats.
-  base::Timer heartbeat_timer_;
+  base::Timer* heartbeat_timer_;

[Daniel Erat, 2014/10/15 15:04:22]

please document the ownership of this pointer

[Chirantan Ekbote, 2014/10/16 21:26:38]

Done.

 
   // Callbacks for interacting with the the connection.
   base::Closure send_heartbeat_callback_;
   base::Closure trigger_reconnect_callback_;
 
   base::WeakPtrFactory<HeartbeatManager> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(HeartbeatManager);
 };
 
 }  // namespace gcm
 
 #endif  // GOOGLE_APIS_GCM_ENGINE_HEARTBEAT_MANAGER_H_