Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: tools/perf/measurements/startup.py

Issue 641823004: telemetry: Allow page tests to be configured via constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Add debug output to figure out why pixel tests fail on bots. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/skpicture_printer.py ('k') | tools/perf/measurements/thread_times.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/startup.py
diff --git a/tools/perf/measurements/startup.py b/tools/perf/measurements/startup.py
index 6d26ee92a1a1b00e43ea42752d15bb2a18366dd9..dce938aa56a982dbe4e0437c4616a7502ec1fb54 100644
--- a/tools/perf/measurements/startup.py
+++ b/tools/perf/measurements/startup.py
@@ -18,17 +18,16 @@ class Startup(page_test.PageTest):
def __init__(self, action_name_to_run = ''):
super(Startup, self).__init__(needs_browser_restart_after_each_page=True,
action_name_to_run=action_name_to_run)
+ self._cold = False
- @classmethod
- def AddCommandLineArgs(cls, parser):
+ def AddCommandLineArgs(self, parser):
parser.add_option('--cold', action='store_true',
help='Clear the OS disk cache before performing the test')
parser.add_option('--warm', action='store_true',
help='Start up with everything already cached')
- @classmethod
- def ProcessCommandLineArgs(cls, parser, args):
- cls._cold = args.cold
+ def ProcessCommandLineArgs(self, parser, args):
+ self._cold = args.cold
# TODO: Once the bots start running benchmarks, enforce that either --warm
# or --cold is explicitly specified.
# if args.warm == args.cold:
« no previous file with comments | « tools/perf/measurements/skpicture_printer.py ('k') | tools/perf/measurements/thread_times.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698