Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: tools/perf/measurements/startup.py

Issue 641823004: telemetry: Allow page tests to be configured via constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Add debug output to figure out why pixel tests fail on bots. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/measurements/skpicture_printer.py ('k') | tools/perf/measurements/thread_times.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from metrics import startup_metric 5 from metrics import startup_metric
6 from telemetry.page import page_test 6 from telemetry.page import page_test
7 7
8 8
9 class Startup(page_test.PageTest): 9 class Startup(page_test.PageTest):
10 """Performs a measurement of Chromium's startup performance. 10 """Performs a measurement of Chromium's startup performance.
11 11
12 This test must be invoked with either --warm or --cold on the command line. A 12 This test must be invoked with either --warm or --cold on the command line. A
13 cold start means none of the Chromium files are in the disk cache. A warm 13 cold start means none of the Chromium files are in the disk cache. A warm
14 start assumes the OS has already cached much of Chromium's content. For warm 14 start assumes the OS has already cached much of Chromium's content. For warm
15 tests, you should repeat the page set to ensure it's cached. 15 tests, you should repeat the page set to ensure it's cached.
16 """ 16 """
17 17
18 def __init__(self, action_name_to_run = ''): 18 def __init__(self, action_name_to_run = ''):
19 super(Startup, self).__init__(needs_browser_restart_after_each_page=True, 19 super(Startup, self).__init__(needs_browser_restart_after_each_page=True,
20 action_name_to_run=action_name_to_run) 20 action_name_to_run=action_name_to_run)
21 self._cold = False
21 22
22 @classmethod 23 def AddCommandLineArgs(self, parser):
23 def AddCommandLineArgs(cls, parser):
24 parser.add_option('--cold', action='store_true', 24 parser.add_option('--cold', action='store_true',
25 help='Clear the OS disk cache before performing the test') 25 help='Clear the OS disk cache before performing the test')
26 parser.add_option('--warm', action='store_true', 26 parser.add_option('--warm', action='store_true',
27 help='Start up with everything already cached') 27 help='Start up with everything already cached')
28 28
29 @classmethod 29 def ProcessCommandLineArgs(self, parser, args):
30 def ProcessCommandLineArgs(cls, parser, args): 30 self._cold = args.cold
31 cls._cold = args.cold
32 # TODO: Once the bots start running benchmarks, enforce that either --warm 31 # TODO: Once the bots start running benchmarks, enforce that either --warm
33 # or --cold is explicitly specified. 32 # or --cold is explicitly specified.
34 # if args.warm == args.cold: 33 # if args.warm == args.cold:
35 # parser.error('You must specify either --warm or --cold') 34 # parser.error('You must specify either --warm or --cold')
36 35
37 def CustomizeBrowserOptions(self, options): 36 def CustomizeBrowserOptions(self, options):
38 if self._cold: 37 if self._cold:
39 options.clear_sytem_cache_for_browser_and_profile_on_start = True 38 options.clear_sytem_cache_for_browser_and_profile_on_start = True
40 else: 39 else:
41 self.discard_first_result = True 40 self.discard_first_result = True
(...skipping 17 matching lines...) Expand all
59 cold start means none of the Chromium files are in the disk cache. A warm 58 cold start means none of the Chromium files are in the disk cache. A warm
60 start assumes the OS has already cached much of Chromium's content. For warm 59 start assumes the OS has already cached much of Chromium's content. For warm
61 tests, you should repeat the page set to ensure it's cached. 60 tests, you should repeat the page set to ensure it's cached.
62 61
63 The startup URL is taken from the page set's startup_url. This 62 The startup URL is taken from the page set's startup_url. This
64 allows the testing of multiple different URLs in a single benchmark. 63 allows the testing of multiple different URLs in a single benchmark.
65 """ 64 """
66 65
67 def __init__(self): 66 def __init__(self):
68 super(StartWithUrl, self).__init__(action_name_to_run='RunNavigateSteps') 67 super(StartWithUrl, self).__init__(action_name_to_run='RunNavigateSteps')
OLDNEW
« no previous file with comments | « tools/perf/measurements/skpicture_printer.py ('k') | tools/perf/measurements/thread_times.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698