Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: tools/perf/measurements/skpicture_printer.py

Issue 641823004: telemetry: Allow page tests to be configured via constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Add debug output to figure out why pixel tests fail on bots. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/screenshot.py ('k') | tools/perf/measurements/startup.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/skpicture_printer.py
diff --git a/tools/perf/measurements/skpicture_printer.py b/tools/perf/measurements/skpicture_printer.py
index 687cf0cd4d7caa1cc73c5b7bdd7337ffa115ad06..5ac9462ce090dc00410e5e1b9bdaed00a972a754 100644
--- a/tools/perf/measurements/skpicture_printer.py
+++ b/tools/perf/measurements/skpicture_printer.py
@@ -12,16 +12,18 @@ _JS = 'chrome.gpuBenchmarking.printToSkPicture("{0}");'
class SkpicturePrinter(page_test.PageTest):
- @classmethod
- def AddCommandLineArgs(cls, parser):
+ def __init__(self):
+ super(SkpicturePrinter, self).__init__()
+ self._skp_outdir = None
+
+ def AddCommandLineArgs(self, parser):
parser.add_option('-s', '--skp-outdir',
help='Output directory for the SKP files')
- @classmethod
- def ProcessCommandLineArgs(cls, parser, args):
+ def ProcessCommandLineArgs(self, parser, args):
if not args.skp_outdir:
parser.error('Please specify --skp-outdir')
- cls._skp_outdir = args.skp_outdir
+ self._skp_outdir = args.skp_outdir
def CustomizeBrowserOptions(self, options):
options.AppendExtraBrowserArgs(['--enable-gpu-benchmarking',
« no previous file with comments | « tools/perf/measurements/screenshot.py ('k') | tools/perf/measurements/startup.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698