Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1882)

Unified Diff: tools/perf/measurements/page_cycler.py

Issue 641823004: telemetry: Allow page tests to be configured via constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Add debug output to figure out why pixel tests fail on bots. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/benchmark_unittest.py ('k') | tools/perf/measurements/rasterize_and_record_micro.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/page_cycler.py
diff --git a/tools/perf/measurements/page_cycler.py b/tools/perf/measurements/page_cycler.py
index d70b9110dcbe20518aaac9b306cf5f0ee7aebe63..f0fc6b341107ee5399ab858b9ff3135ab4f85e7f 100644
--- a/tools/perf/measurements/page_cycler.py
+++ b/tools/perf/measurements/page_cycler.py
@@ -46,9 +46,11 @@ class PageCycler(page_test.PageTest):
self._v8_object_stats_metric = None
self._has_loaded_page = collections.defaultdict(int)
self._initial_renderer_url = None # to avoid cross-renderer navigation
+ self._record_v8_object_stats = False
+ self._report_speed_index = False
+ self._cold_run_start_index = None
- @classmethod
- def AddCommandLineArgs(cls, parser):
+ def AddCommandLineArgs(self, parser):
parser.add_option('--v8-object-stats',
action='store_true',
help='Enable detailed V8 object statistics.')
@@ -60,10 +62,9 @@ class PageCycler(page_test.PageTest):
parser.add_option('--cold-load-percent', type='int', default=50,
help='%d of page visits for which a cold load is forced')
- @classmethod
- def ProcessCommandLineArgs(cls, parser, args):
- cls._record_v8_object_stats = args.v8_object_stats
- cls._report_speed_index = args.report_speed_index
+ def ProcessCommandLineArgs(self, parser, args):
+ self._record_v8_object_stats = args.v8_object_stats
+ self._report_speed_index = args.report_speed_index
cold_runs_percent_set = (args.cold_load_percent != None)
# Handle requests for cold cache runs
@@ -78,11 +79,11 @@ class PageCycler(page_test.PageTest):
number_warm_pageset_runs = int(
(int(args.pageset_repeat) - 1) * (100 - args.cold_load_percent) / 100)
number_warm_runs = number_warm_pageset_runs * args.page_repeat
- cls._cold_run_start_index = number_warm_runs + args.page_repeat
- cls.discard_first_result = (not args.cold_load_percent or
- cls.discard_first_result)
+ self._cold_run_start_index = number_warm_runs + args.page_repeat
+ self.discard_first_result = (not args.cold_load_percent or
+ self.discard_first_result)
else:
- cls._cold_run_start_index = args.pageset_repeat * args.page_repeat
+ self._cold_run_start_index = args.pageset_repeat * args.page_repeat
def WillStartBrowser(self, platform):
"""Initialize metrics once right before the browser has been launched."""
« no previous file with comments | « tools/perf/benchmarks/benchmark_unittest.py ('k') | tools/perf/measurements/rasterize_and_record_micro.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698