tools/perf/benchmarks/benchmark_unittest.py - Issue 641823004: telemetry: Allow page tests to be configured via constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/benchmark_unittest.py

Issue 641823004: telemetry: Allow page tests to be configured via constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: Add debug output to figure out why pixel tests fail on bots. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/benchmark_unittest.py

diff --git a/tools/perf/benchmarks/benchmark_unittest.py b/tools/perf/benchmarks/benchmark_unittest.py

index f2437730e8c027f709f5698298ecbef43775c2df..dd5c677f777ab18bc02bc5a377ca8c270c5c0ad2 100644

--- a/tools/perf/benchmarks/benchmark_unittest.py

+++ b/tools/perf/benchmarks/benchmark_unittest.py

@@ -18,11 +18,12 @@ def _GetPerfDir(*subdirs):

return os.path.join(perf_dir, *subdirs)

-def _BenchmarkOptionsTestGenerator(benchmark):

+def _BenchmarkOptionsTestGenerator(benchmark_class):

def testBenchmarkOptions(self): # pylint: disable=W0613

"""Invalid options will raise benchmark.InvalidOptionsError."""

options = browser_options.BrowserFinderOptions()

parser = options.CreateParser()

+ benchmark = benchmark_class()

benchmark.AddCommandLineArgs(parser)

benchmark_module.AddCommandLineArgs(parser)

benchmark.SetArgumentDefaults(parser)

« no previous file with comments | « tools/perf/benchmarks/benchmark_smoke_unittest.py ('k') | tools/perf/measurements/page_cycler.py » ('j') | no next file with comments »