Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 641753002: Remove Password Authentication code that is no longer used. (Closed)

Created:
6 years, 2 months ago by aurimas (slooooooooow)
Modified:
6 years, 2 months ago
Reviewers:
Ted C, Ilya Sherman
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove Password Authentication code that is no longer used. BUG=421254 Committed: https://crrev.com/de35ea60c964deef8fa238814e608389e9e13111 Cr-Commit-Position: refs/heads/master@{#298768}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -385 lines) Patch
D chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBarDelegate.java View 1 chunk +0 lines, -54 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 4 chunks +0 lines, -5 lines 0 comments Download
D chrome/browser/android/password_authentication_manager.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/android/password_authentication_manager.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate.h View 1 chunk +1 line, -10 lines 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate.cc View 3 chunks +3 lines, -25 lines 1 comment Download
M chrome/browser/ui/android/infobars/confirm_infobar.h View 2 chunks +1 line, -2 lines 0 comments Download
D chrome/browser/ui/android/infobars/save_password_infobar.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/ui/android/infobars/save_password_infobar.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
aurimas (slooooooooow)
Hey Ted, PTAL. Aurimas
6 years, 2 months ago (2014-10-08 17:46:09 UTC) #2
Ted C
lgtm
6 years, 2 months ago (2014-10-08 18:14:16 UTC) #3
aurimas (slooooooooow)
Hey Ilya, Please take a look at this change. Thanks, Aurimas
6 years, 2 months ago (2014-10-08 18:17:14 UTC) #5
Ilya Sherman
https://chromiumcodereview.appspot.com/641753002/diff/1/chrome/browser/password_manager/save_password_infobar_delegate.cc File chrome/browser/password_manager/save_password_infobar_delegate.cc (left): https://chromiumcodereview.appspot.com/641753002/diff/1/chrome/browser/password_manager/save_password_infobar_delegate.cc#oldcode80 chrome/browser/password_manager/save_password_infobar_delegate.cc:80: form_to_save_->SetUseAdditionalPasswordAuthentication( It looks like SetUseAdditionalPasswordAuthentication() can be removed from ...
6 years, 2 months ago (2014-10-08 18:58:22 UTC) #6
aurimas (slooooooooow)
On 2014/10/08 18:58:22, Ilya Sherman wrote: > https://chromiumcodereview.appspot.com/641753002/diff/1/chrome/browser/password_manager/save_password_infobar_delegate.cc > File chrome/browser/password_manager/save_password_infobar_delegate.cc (left): > > https://chromiumcodereview.appspot.com/641753002/diff/1/chrome/browser/password_manager/save_password_infobar_delegate.cc#oldcode80 ...
6 years, 2 months ago (2014-10-08 21:05:21 UTC) #7
Ilya Sherman
Okay. This CL LGTM, then.
6 years, 2 months ago (2014-10-08 21:06:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641753002/1
6 years, 2 months ago (2014-10-08 21:16:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5c5627ba5e354e9dc03e4fd5caef4ee11f18e96d
6 years, 2 months ago (2014-10-09 04:38:01 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 04:38:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de35ea60c964deef8fa238814e608389e9e13111
Cr-Commit-Position: refs/heads/master@{#298768}

Powered by Google App Engine
This is Rietveld 408576698