Remove Password Authentication code that is no longer used.

chrome/browser/password_manager/save_password_infobar_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/save_password_infobar_delegate.h"
 
 #include "base/metrics/histogram.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/ui/sync/one_click_signin_helper.h"
@@ skipping 26 matching lines @@
       switches::IsEnableWebBasedSignin() &&
       OneClickSigninHelper::CanOffer(
           web_contents,
           OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
           base::UTF16ToUTF8(form_to_save->associated_username()),
           NULL))
     return;
 #endif
 
   InfoBarService::FromWebContents(web_contents)->AddInfoBar(
-      SavePasswordInfoBarDelegate::CreateInfoBar(
-          scoped_ptr<SavePasswordInfoBarDelegate>(
-              new SavePasswordInfoBarDelegate(form_to_save.Pass(),
-                                              uma_histogram_suffix))));
+      ConfirmInfoBarDelegate::CreateInfoBar(scoped_ptr<ConfirmInfoBarDelegate>(
+          new SavePasswordInfoBarDelegate(form_to_save.Pass(),
+                                          uma_histogram_suffix))));
 }
 
 SavePasswordInfoBarDelegate::~SavePasswordInfoBarDelegate() {
   UMA_HISTOGRAM_ENUMERATION("PasswordManager.InfoBarResponse",
                             infobar_response_,
                             password_manager::metrics_util::NUM_RESPONSE_TYPES);
 
   password_manager::metrics_util::LogUIDismissalReason(infobar_response_);
 
   // The shortest period for which the prompt needs to live, so that we don't
   // consider it killed prematurely, as might happen, e.g., if a pre-rendered
   // page gets swapped in (and the current WebContents is destroyed).
   const base::TimeDelta kMinimumPromptDisplayTime =
       base::TimeDelta::FromSeconds(1);
 
   if (!uma_histogram_suffix_.empty()) {
     password_manager::metrics_util::LogUMAHistogramEnumeration(
         "PasswordManager.SavePasswordPromptResponse_" + uma_histogram_suffix_,
         infobar_response_,
         password_manager::metrics_util::NUM_RESPONSE_TYPES);
     password_manager::metrics_util::LogUMAHistogramBoolean(
         "PasswordManager.SavePasswordPromptDisappearedQuickly_" +
             uma_histogram_suffix_,
         timer_.Elapsed() < kMinimumPromptDisplayTime);
   }
 }
 
-void SavePasswordInfoBarDelegate::SetUseAdditionalPasswordAuthentication(
-    bool use_additional_authentication) {
-  form_to_save_->SetUseAdditionalPasswordAuthentication(

[Ilya Sherman, 2014/10/08 18:58:22]

It looks like SetUseAdditionalPasswordAuthentication() can be removed from the
PasswordFormManager class as well.  Indeed, there are a bunch more changes
linked in [ https://code.google.com/p/chromium/issues/detail?id=341492 ].  Can
more of this code be removed?  Are you planning to send separate CLs for that
work?

-      use_additional_authentication);
-}
-
 SavePasswordInfoBarDelegate::SavePasswordInfoBarDelegate(
     scoped_ptr<password_manager::PasswordFormManager> form_to_save,
     const std::string& uma_histogram_suffix)
     : ConfirmInfoBarDelegate(),
       form_to_save_(form_to_save.Pass()),
       infobar_response_(password_manager::metrics_util::NO_RESPONSE),
       uma_histogram_suffix_(uma_histogram_suffix) {
   if (!uma_histogram_suffix_.empty()) {
     password_manager::metrics_util::LogUMAHistogramBoolean(
         "PasswordManager.SavePasswordPromptDisplayed_" + uma_histogram_suffix_,
         true);
   }
 }
 
-#if !defined(OS_ANDROID)
-// On Android, the save password infobar supports an additional checkbox to
-// require additional authentication before autofilling a saved password.
-// Because of this non-standard UI, the Android version is special cased and
-// constructed in:
-// chrome/browser/ui/android/infobars/save_password_infobar.cc
-
-// static
-scoped_ptr<infobars::InfoBar> SavePasswordInfoBarDelegate::CreateInfoBar(
-    scoped_ptr<SavePasswordInfoBarDelegate> delegate) {
-  return ConfirmInfoBarDelegate::CreateInfoBar(
-      delegate.PassAs<ConfirmInfoBarDelegate>());
-}
-#endif
-
 bool SavePasswordInfoBarDelegate::ShouldExpire(
     const NavigationDetails& details) const {
   return !details.is_redirect &&
          infobars::InfoBarDelegate::ShouldExpire(details);
 }
 
 int SavePasswordInfoBarDelegate::GetIconID() const {
   return IDR_INFOBAR_SAVE_PASSWORD;
 }
 
@@ skipping 28 matching lines @@
 
 void SavePasswordInfoBarDelegate::InfoBarDismissed() {
   DCHECK(form_to_save_.get());
   infobar_response_ = password_manager::metrics_util::INFOBAR_DISMISSED;
 }
 
 infobars::InfoBarDelegate::InfoBarAutomationType
 SavePasswordInfoBarDelegate::GetInfoBarAutomationType() const {
   return PASSWORD_INFOBAR;
 }