device/battery/android/BUILD.gn - Issue 641703002: Rewrite the Android implementation of BatteryMonitor directly in Java.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/battery/android/BUILD.gn

Issue 641703002: Rewrite the Android implementation of BatteryMonitor directly in Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@battery-status-api-to-mojo

Patch Set: Address Ben's comments, update GN build, polish. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/ServiceRegistrar.java ('K') | « device/battery/BUILD.gn ('k') | device/battery/android/battery_jni_registrar.h » ('j') | device/battery/android/java/src/org/chromium/device/battery/BatteryMonitorFactory.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/battery/android/BUILD.gn

diff --git a/device/battery/android/BUILD.gn b/device/battery/android/BUILD.gn

index f88cfc0b3deee30d6e91850be43bee8cc5a8f7c6..ea4d5cc84bd146059049a58bdc9bbaa2b7de7ae3 100644

--- a/device/battery/android/BUILD.gn

+++ b/device/battery/android/BUILD.gn

@@ -5,9 +5,17 @@

import("//build/config/android/config.gni")

import("//build/config/android/rules.gni")

-generate_jni("battery_jni_headers") {

- jni_package = "battery"

- sources = [

+android_library("battery_monitor_android") {

+ java_files = [

"java/src/org/chromium/device/battery/BatteryStatusManager.java",

+ "java/src/org/chromium/device/battery/BatteryMonitorImpl.java",

+ "java/src/org/chromium/device/battery/BatteryMonitorFactory.java",

+ ]

+ deps = [

+ "//base:base_java",

+ "//device/battery:mojo_bindings_java",

+ "//mojo/public/java:bindings",

+ "//mojo/public/java:system",

]

}