device/battery/BUILD.gn - Issue 641703002: Rewrite the Android implementation of BatteryMonitor directly in Java.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/battery/BUILD.gn

Issue 641703002: Rewrite the Android implementation of BatteryMonitor directly in Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@battery-status-api-to-mojo

Patch Set: Address Ben's comments, update GN build, polish. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/ServiceRegistrar.java ('K') | « content/shell/browser/shell_mojo_test_utils_android.cc ('k') | device/battery/android/BUILD.gn » ('j') | device/battery/android/java/src/org/chromium/device/battery/BatteryMonitorFactory.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/battery/BUILD.gn

diff --git a/device/battery/BUILD.gn b/device/battery/BUILD.gn

index 5a633743335bb73c2648ecc055f6849ee7898659..e3afef718bcf3d3fbab41e2e2c4ea6764ecd13ce 100644

--- a/device/battery/BUILD.gn

+++ b/device/battery/BUILD.gn

@@ -12,8 +12,6 @@ component("battery") {

"battery_export.h",

"battery_monitor_impl.cc",

"battery_monitor_impl.h",

- "battery_status_manager_android.cc",

- "battery_status_manager_android.h",

"battery_status_manager_chromeos.cc",

"battery_status_manager_default.cc",

"battery_status_manager_linux.cc",

@@ -36,15 +34,6 @@ component("battery") {

"//mojo/edk/system",

]

- if (is_android) {

- deps += [ "//device/battery/android:battery_jni_headers" ]

- sources += [

- "android/battery_jni_registrar.h",

- "android/battery_jni_registrar.cc",

- ]

- sources -= [ "battery_status_manager_default.cc" ]

- }

if (is_chromeos) {

configs += [ "//build/config/linux:dbus" ]

deps += [ "//chromeos:power_manager_proto" ]