athena/content/content_proxy.cc - Issue 641683003: C++11 override style change for athena

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/content/content_proxy.cc

Issue 641683003: C++11 override style change for athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: athena/content/content_proxy.cc

diff --git a/athena/content/content_proxy.cc b/athena/content/content_proxy.cc

index f2a2f137a9f2c18cd8beef70aeab7493d88c953e..0e7cfbee6c36cfb9631ba4fd1460e1c25320afe7 100644

--- a/athena/content/content_proxy.cc

+++ b/athena/content/content_proxy.cc

@@ -42,8 +42,7 @@ class ProxyImageData : public base::RefCountedThreadSafe<ProxyImageData> {

private:

friend class base::RefCountedThreadSafe<ProxyImageData>;

- virtual ~ProxyImageData() {

oshima 2014/10/23 19:07:31 This turns out to be unnecessary. having virtual i

- }

+ ~ProxyImageData() {}

void EncodeOnWorker(const SkBitmap& bitmap) {

DCHECK_EQ(bitmap.colorType(), kAlpha_8_SkColorType);