Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Side by Side Diff: athena/input/accelerator_manager_impl.cc

Issue 641683003: C++11 override style change for athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "athena/input/accelerator_manager_impl.h" 5 #include "athena/input/accelerator_manager_impl.h"
6 6
7 #include "athena/input/public/input_manager.h" 7 #include "athena/input/public/input_manager.h"
8 #include "athena/util/switches.h" 8 #include "athena/util/switches.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "ui/aura/window.h" 10 #include "ui/aura/window.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 // wm::NestedAcceleratorController while accelerators in normal case are 42 // wm::NestedAcceleratorController while accelerators in normal case are
43 // handled by wm::AcceleratorFilter. These delegates act bridges in these 43 // handled by wm::AcceleratorFilter. These delegates act bridges in these
44 // two different environment so that AcceleratorManagerImpl can handle 44 // two different environment so that AcceleratorManagerImpl can handle
45 // accelerators in an uniform way. 45 // accelerators in an uniform way.
46 46
47 class NestedAcceleratorDelegate : public wm::NestedAcceleratorDelegate { 47 class NestedAcceleratorDelegate : public wm::NestedAcceleratorDelegate {
48 public: 48 public:
49 explicit NestedAcceleratorDelegate( 49 explicit NestedAcceleratorDelegate(
50 AcceleratorManagerImpl* accelerator_manager) 50 AcceleratorManagerImpl* accelerator_manager)
51 : accelerator_manager_(accelerator_manager) {} 51 : accelerator_manager_(accelerator_manager) {}
52 virtual ~NestedAcceleratorDelegate() {} 52 ~NestedAcceleratorDelegate() override {}
53 53
54 private: 54 private:
55 // wm::NestedAcceleratorDelegate: 55 // wm::NestedAcceleratorDelegate:
56 virtual Result ProcessAccelerator( 56 Result ProcessAccelerator(
57 const ui::Accelerator& accelerator) override { 57 const ui::Accelerator& accelerator) override {
58 return accelerator_manager_->Process(accelerator) ? RESULT_PROCESSED 58 return accelerator_manager_->Process(accelerator) ? RESULT_PROCESSED
59 : RESULT_NOT_PROCESSED; 59 : RESULT_NOT_PROCESSED;
60 } 60 }
61 61
62 AcceleratorManagerImpl* accelerator_manager_; 62 AcceleratorManagerImpl* accelerator_manager_;
63 63
64 DISALLOW_COPY_AND_ASSIGN(NestedAcceleratorDelegate); 64 DISALLOW_COPY_AND_ASSIGN(NestedAcceleratorDelegate);
65 }; 65 };
66 66
67 class AcceleratorDelegate : public wm::AcceleratorDelegate { 67 class AcceleratorDelegate : public wm::AcceleratorDelegate {
68 public: 68 public:
69 explicit AcceleratorDelegate(AcceleratorManagerImpl* accelerator_manager) 69 explicit AcceleratorDelegate(AcceleratorManagerImpl* accelerator_manager)
70 : accelerator_manager_(accelerator_manager) {} 70 : accelerator_manager_(accelerator_manager) {}
71 virtual ~AcceleratorDelegate() {} 71 ~AcceleratorDelegate() override {}
72 72
73 private: 73 private:
74 // wm::AcceleratorDelegate: 74 // wm::AcceleratorDelegate:
75 virtual bool ProcessAccelerator(const ui::KeyEvent& event, 75 bool ProcessAccelerator(const ui::KeyEvent& event,
76 const ui::Accelerator& accelerator, 76 const ui::Accelerator& accelerator,
77 KeyType key_type) override { 77 KeyType key_type) override {
78 aura::Window* target = static_cast<aura::Window*>(event.target()); 78 aura::Window* target = static_cast<aura::Window*>(event.target());
79 if (!target->IsRootWindow() && 79 if (!target->IsRootWindow() &&
80 !accelerator_manager_->IsRegistered(accelerator, AF_RESERVED)) { 80 !accelerator_manager_->IsRegistered(accelerator, AF_RESERVED)) {
81 // TODO(oshima): do the same when the active window is in fullscreen. 81 // TODO(oshima): do the same when the active window is in fullscreen.
82 return false; 82 return false;
83 } 83 }
84 return accelerator_manager_->Process(accelerator); 84 return accelerator_manager_->Process(accelerator);
85 } 85 }
86 86
87 AcceleratorManagerImpl* accelerator_manager_; 87 AcceleratorManagerImpl* accelerator_manager_;
88 DISALLOW_COPY_AND_ASSIGN(AcceleratorDelegate); 88 DISALLOW_COPY_AND_ASSIGN(AcceleratorDelegate);
89 }; 89 };
90 90
91 class FocusManagerDelegate : public views::FocusManagerDelegate { 91 class FocusManagerDelegate : public views::FocusManagerDelegate {
92 public: 92 public:
93 explicit FocusManagerDelegate(AcceleratorManagerImpl* accelerator_manager) 93 explicit FocusManagerDelegate(AcceleratorManagerImpl* accelerator_manager)
94 : accelerator_manager_(accelerator_manager) {} 94 : accelerator_manager_(accelerator_manager) {}
95 virtual ~FocusManagerDelegate() {} 95 ~FocusManagerDelegate() override {}
96 96
97 virtual bool ProcessAccelerator(const ui::Accelerator& accelerator) override { 97 bool ProcessAccelerator(const ui::Accelerator& accelerator) override {
98 return accelerator_manager_->Process(accelerator); 98 return accelerator_manager_->Process(accelerator);
99 } 99 }
100 100
101 virtual ui::AcceleratorTarget* GetCurrentTargetForAccelerator( 101 ui::AcceleratorTarget* GetCurrentTargetForAccelerator(
102 const ui::Accelerator& accelerator) const override { 102 const ui::Accelerator& accelerator) const override {
103 return accelerator_manager_->IsRegistered(accelerator, AF_NONE) 103 return accelerator_manager_->IsRegistered(accelerator, AF_NONE)
104 ? accelerator_manager_ 104 ? accelerator_manager_
105 : NULL; 105 : NULL;
106 } 106 }
107 107
108 private: 108 private:
109 AcceleratorManagerImpl* accelerator_manager_; 109 AcceleratorManagerImpl* accelerator_manager_;
110 110
111 DISALLOW_COPY_AND_ASSIGN(FocusManagerDelegate); 111 DISALLOW_COPY_AND_ASSIGN(FocusManagerDelegate);
112 }; 112 };
113 113
114 // Key strokes must be sent to web contents to give them a chance to 114 // Key strokes must be sent to web contents to give them a chance to
115 // consume them unless they are reserved, and unhandled key events are 115 // consume them unless they are reserved, and unhandled key events are
116 // sent back to focus manager asynchronously. This installs the athena's 116 // sent back to focus manager asynchronously. This installs the athena's
117 // focus manager that handles athena shell's accelerators. 117 // focus manager that handles athena shell's accelerators.
118 class FocusManagerFactory : public views::FocusManagerFactory { 118 class FocusManagerFactory : public views::FocusManagerFactory {
119 public: 119 public:
120 explicit FocusManagerFactory(AcceleratorManagerImpl* accelerator_manager) 120 explicit FocusManagerFactory(AcceleratorManagerImpl* accelerator_manager)
121 : accelerator_manager_(accelerator_manager) {} 121 : accelerator_manager_(accelerator_manager) {}
122 virtual ~FocusManagerFactory() {} 122 ~FocusManagerFactory() override {}
123 123
124 virtual views::FocusManager* CreateFocusManager( 124 views::FocusManager* CreateFocusManager(
125 views::Widget* widget, 125 views::Widget* widget,
126 bool desktop_widget) override { 126 bool desktop_widget) override {
127 return new views::FocusManager( 127 return new views::FocusManager(
128 widget, 128 widget,
129 desktop_widget ? NULL : new FocusManagerDelegate(accelerator_manager_)); 129 desktop_widget ? NULL : new FocusManagerDelegate(accelerator_manager_));
130 } 130 }
131 131
132 private: 132 private:
133 AcceleratorManagerImpl* accelerator_manager_; 133 AcceleratorManagerImpl* accelerator_manager_;
134 134
135 DISALLOW_COPY_AND_ASSIGN(FocusManagerFactory); 135 DISALLOW_COPY_AND_ASSIGN(FocusManagerFactory);
136 }; 136 };
137 137
138 class UIAcceleratorManagerWrapper 138 class UIAcceleratorManagerWrapper
139 : public AcceleratorManagerImpl::AcceleratorWrapper { 139 : public AcceleratorManagerImpl::AcceleratorWrapper {
140 public: 140 public:
141 UIAcceleratorManagerWrapper() 141 UIAcceleratorManagerWrapper()
142 : ui_accelerator_manager_(new ui::AcceleratorManager) {} 142 : ui_accelerator_manager_(new ui::AcceleratorManager) {}
143 virtual ~UIAcceleratorManagerWrapper() {} 143 ~UIAcceleratorManagerWrapper() override {}
144 144
145 virtual void Register(const ui::Accelerator& accelerator, 145 virtual void Register(const ui::Accelerator& accelerator,
146 ui::AcceleratorTarget* target) override { 146 ui::AcceleratorTarget* target) override {
147 ui_accelerator_manager_->Register( 147 ui_accelerator_manager_->Register(
148 accelerator, ui::AcceleratorManager::kNormalPriority, target); 148 accelerator, ui::AcceleratorManager::kNormalPriority, target);
149 } 149 }
150 150
151 virtual void Unregister(const ui::Accelerator& accelerator, 151 virtual void Unregister(const ui::Accelerator& accelerator,
152 ui::AcceleratorTarget* target) override { 152 ui::AcceleratorTarget* target) override {
153 ui_accelerator_manager_->Unregister(accelerator, target); 153 ui_accelerator_manager_->Unregister(accelerator, target);
(...skipping 11 matching lines...) Expand all
165 private: 165 private:
166 scoped_ptr<ui::AcceleratorManager> ui_accelerator_manager_; 166 scoped_ptr<ui::AcceleratorManager> ui_accelerator_manager_;
167 167
168 DISALLOW_COPY_AND_ASSIGN(UIAcceleratorManagerWrapper); 168 DISALLOW_COPY_AND_ASSIGN(UIAcceleratorManagerWrapper);
169 }; 169 };
170 170
171 class FocusManagerWrapper : public AcceleratorManagerImpl::AcceleratorWrapper { 171 class FocusManagerWrapper : public AcceleratorManagerImpl::AcceleratorWrapper {
172 public: 172 public:
173 explicit FocusManagerWrapper(views::FocusManager* focus_manager) 173 explicit FocusManagerWrapper(views::FocusManager* focus_manager)
174 : focus_manager_(focus_manager) {} 174 : focus_manager_(focus_manager) {}
175 virtual ~FocusManagerWrapper() {} 175 ~FocusManagerWrapper() override {}
176 176
177 virtual void Register(const ui::Accelerator& accelerator, 177 virtual void Register(const ui::Accelerator& accelerator,
178 ui::AcceleratorTarget* target) override { 178 ui::AcceleratorTarget* target) override {
179 return focus_manager_->RegisterAccelerator( 179 return focus_manager_->RegisterAccelerator(
180 accelerator, ui::AcceleratorManager::kNormalPriority, target); 180 accelerator, ui::AcceleratorManager::kNormalPriority, target);
181 } 181 }
182 182
183 virtual void Unregister(const ui::Accelerator& accelerator, 183 virtual void Unregister(const ui::Accelerator& accelerator,
184 ui::AcceleratorTarget* target) override { 184 ui::AcceleratorTarget* target) override {
185 focus_manager_->UnregisterAccelerator(accelerator, target); 185 focus_manager_->UnregisterAccelerator(accelerator, target);
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 return InputManager::Get()->GetAcceleratorManager(); 353 return InputManager::Get()->GetAcceleratorManager();
354 } 354 }
355 355
356 // static 356 // static
357 scoped_ptr<AcceleratorManager> AcceleratorManager::CreateForFocusManager( 357 scoped_ptr<AcceleratorManager> AcceleratorManager::CreateForFocusManager(
358 views::FocusManager* focus_manager) { 358 views::FocusManager* focus_manager) {
359 return AcceleratorManagerImpl::CreateForFocusManager(focus_manager).Pass(); 359 return AcceleratorManagerImpl::CreateForFocusManager(focus_manager).Pass();
360 } 360 }
361 361
362 } // namespace athena 362 } // namespace athena
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698