Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issue 641613003: Rearrange code in TextContexts to be more consistent. (Closed)

Created:
6 years, 2 months ago by jvanverth1
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Rearrange code in TextContexts to be more consistent and match style guide. Committed: https://skia.googlesource.com/skia/+/0fedb19812f05fcf18d16f0e96000768f4f76b11

Patch Set 1 #

Patch Set 2 : Clean up some formatting #

Patch Set 3 : One more pass #

Patch Set 4 : Stupid comments #

Patch Set 5 : And again. #

Total comments: 6

Patch Set 6 : Some more indention clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+521 lines, -524 lines) Patch
M src/gpu/GrBitmapTextContext.h View 4 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 1 2 3 4 5 12 chunks +130 lines, -129 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.h View 2 chunks +20 lines, -21 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 2 3 4 5 10 chunks +312 lines, -317 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.h View 4 chunks +14 lines, -13 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 2 chunks +24 lines, -24 lines 0 comments Download
M src/gpu/GrTextContext.h View 3 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jvanverth1
6 years, 2 months ago (2014-10-08 14:48:30 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/641613003/diff/80001/src/gpu/GrBitmapTextContext.cpp File src/gpu/GrBitmapTextContext.cpp (right): https://codereview.chromium.org/641613003/diff/80001/src/gpu/GrBitmapTextContext.cpp#newcode165 src/gpu/GrBitmapTextContext.cpp:165: this->appendGlyph(GrGlyph::Pack(glyph.getGlyphID(), These guys go right a bit ? ...
6 years, 2 months ago (2014-10-08 15:10:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641613003/100001
6 years, 2 months ago (2014-10-08 15:47:14 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 16:07:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as 0fedb19812f05fcf18d16f0e96000768f4f76b11

Powered by Google App Engine
This is Rietveld 408576698