Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Unified Diff: minidump/minidump_module_writer_test.cc

Issue 641603006: Add MinidumpMemoryListWriter::AddFromSnapshot(), everything downstream and its test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Correctly look for the last memory range at EOF Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_module_writer.h ('k') | snapshot/mac/memory_snapshot_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_module_writer_test.cc
diff --git a/minidump/minidump_module_writer_test.cc b/minidump/minidump_module_writer_test.cc
index ae93ad223223c223c3bbe4441669dc3a56f2a175..4bb735cc95ee8e64fdfc12a11ad90828650f431e 100644
--- a/minidump/minidump_module_writer_test.cc
+++ b/minidump/minidump_module_writer_test.cc
@@ -649,16 +649,9 @@ void InitializeTestModuleSnapshotFromMinidumpModule(
TEST(MinidumpModuleWriter, InitializeFromSnapshot) {
MINIDUMP_MODULE expect_modules[3] = {};
- const char* module_paths[3] = {};
- const char* module_names[3] = {};
- UUID uuids[3] = {};
-
- static_assert(arraysize(expect_modules) == arraysize(module_paths),
- "array sizes must be equal");
- static_assert(arraysize(expect_modules) == arraysize(module_names),
- "array sizes must be equal");
- static_assert(arraysize(expect_modules) == arraysize(uuids),
- "array sizes must be equal");
+ const char* module_paths[arraysize(expect_modules)] = {};
+ const char* module_names[arraysize(expect_modules)] = {};
+ UUID uuids[arraysize(expect_modules)] = {};
expect_modules[0].BaseOfImage = 0x100101000;
expect_modules[0].SizeOfImage = 0xf000;
« no previous file with comments | « minidump/minidump_module_writer.h ('k') | snapshot/mac/memory_snapshot_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698