Issue 641563002: Revert of Remove PagePopup runtime flag (status=stable) for chromium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 641563002: Revert of Remove PagePopup runtime flag (status=stable) for chromium (Closed)

Created:
6 years, 2 months ago by tkent

Modified:
6 years, 2 months ago

Reviewers:
Avi (use Gerrit), heeyoun.lee

CC:
chromium-reviews, eseidel, kangil_, pdr., tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Remove PagePopup runtime flag (status=stable) for chromium (patchset #2 id:20001 of https://codereview.chromium.org/586053003/) Reason for revert: Broke <input type=color> UI on Android. Original issue's description: > Remove PagePopup runtime flag (status=stable) for chromium > > BUG=402536 > > Committed: https://crrev.com/a0a8313cd7d7ae41ebd07c5fcba0c8659613fb87 > Cr-Commit-Position: refs/heads/master@{#298665} TBR=avi@chromium.org,heeyoun.lee@samsung.com NOTREECHECKS=true NOTRY=true BUG=402536 Committed: https://crrev.com/88f25328e09d49f122ec9a163a9cb0395f3b9c9d Cr-Commit-Position: refs/heads/master@{#298669}

Created: 6 years, 2 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	content/child/runtime_features.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

tkent

Created Revert of Remove PagePopup runtime flag (status=stable) for chromium

6 years, 2 months ago (2014-10-08 07:43:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641563002/1

6 years, 2 months ago (2014-10-08 07:43:37 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as 976072b3def80ff490dd2b80158f0cab6f068c92

6 years, 2 months ago (2014-10-08 07:44:10 UTC) #3

commit-bot: I haz the power

6 years, 2 months ago (2014-10-08 07:45:17 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/88f25328e09d49f122ec9a163a9cb0395f3b9c9d
Cr-Commit-Position: refs/heads/master@{#298669}