Issue 641553002: Revert of Remove PagePopup runtime flag (status=stable) for blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 641553002: Revert of Remove PagePopup runtime flag (status=stable) for blink (Closed)

Created:
6 years, 2 months ago by tkent

Modified:
6 years, 2 months ago

Reviewers:
heeyoun.lee, eseidel

CC:
blink-reviews, kangil_, pdr., tfarina

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Revert of Remove PagePopup runtime flag (status=stable) for blink (patchset #2 id:20001 of https://codereview.chromium.org/594033002/) Reason for revert: The PagePopup flag is not removable. Original issue's description: > Remove PagePopup runtime flag (status=stable) for blink > > BUG=402536 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183390 TBR=eseidel@chromium.org,heeyoun.lee@samsung.com NOTREECHECKS=true NOTRY=true BUG=402536 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183395

Created: 6 years, 2 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -2 lines)			Patch
M	Source/core/page/PagePopupController.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/page/WindowPagePopup.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/platform/RuntimeEnabledFeatures.in	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/web/ChromeClientImpl.cpp	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	Source/web/WebRuntimeFeatures.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	public/web/WebRuntimeFeatures.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

tkent

Created Revert of Remove PagePopup runtime flag (status=stable) for blink

6 years, 2 months ago (2014-10-08 07:41:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641553002/1

6 years, 2 months ago (2014-10-08 07:41:45 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-08 07:42:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 183395