Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 641523002: Replace OVERRIDE with its C++11 counterparts in src/skia (Closed)

Created:
6 years, 2 months ago by RAGHURAM
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace OVERRIDE with its C++11 counterparts in src/skia This step is a giant search for OVERRIDE to replace it with its lowercase versions. BUG=417463 Committed: https://crrev.com/3c200fad33da10ca7b7bda1bba471d80ac570649 Cr-Commit-Position: refs/heads/master@{#298861}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -120 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M skia/ext/SkDiscardableMemory_chrome.h View 1 chunk +3 lines, -3 lines 0 comments Download
M skia/ext/analysis_canvas.h View 2 chunks +27 lines, -27 lines 0 comments Download
M skia/ext/benchmarking_canvas.cc View 3 chunks +24 lines, -24 lines 0 comments Download
M skia/ext/bitmap_platform_device_cairo.h View 1 chunk +4 lines, -4 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.h View 1 chunk +4 lines, -4 lines 0 comments Download
M skia/ext/bitmap_platform_device_skia.h View 1 chunk +3 lines, -3 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.h View 1 chunk +6 lines, -6 lines 0 comments Download
M skia/ext/event_tracer_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M skia/ext/opacity_draw_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/pixel_ref_utils.cc View 1 13 chunks +17 lines, -17 lines 0 comments Download
M skia/ext/pixel_ref_utils_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M skia/ext/vector_platform_device_emf_win.h View 1 1 chunk +17 lines, -17 lines 0 comments Download
M skia/ext/vector_platform_device_skia.h View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 25 (4 generated)
RAGHURAM
Please review. Thanks & Regards
6 years, 2 months ago (2014-10-08 06:34:12 UTC) #2
f(malita)
Looks good, but while at it let's also replace the SK_OVERRIDEs in skia/ext/pixel_ref_utils.cc. https://codereview.chromium.org/641523002/diff/1/skia/ext/vector_platform_device_emf_win.h File ...
6 years, 2 months ago (2014-10-08 11:55:08 UTC) #3
robertphillips
lgtm modulo the change Florin suggested
6 years, 2 months ago (2014-10-08 12:01:40 UTC) #4
RAGHURAM
6 years, 2 months ago (2014-10-08 12:03:14 UTC) #5
RAGHURAM
On 2014/10/08 11:55:08, Florin Malita wrote: > Looks good, but while at it let's also ...
6 years, 2 months ago (2014-10-08 12:05:26 UTC) #6
robertphillips
lgtm
6 years, 2 months ago (2014-10-08 12:05:51 UTC) #7
f(malita)
LGTM, thanks.
6 years, 2 months ago (2014-10-08 12:06:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641523002/20001
6 years, 2 months ago (2014-10-08 12:07:12 UTC) #10
RAGHURAM
On 2014/10/08 12:06:16, Florin Malita wrote: > LGTM, thanks. The chromium presubmit is failing. Could ...
6 years, 2 months ago (2014-10-08 12:13:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/16258)
6 years, 2 months ago (2014-10-08 12:14:13 UTC) #13
robertphillips
Presumably your company has already filled out a Corporate Contributor License Agreement but I don't ...
6 years, 2 months ago (2014-10-08 12:28:40 UTC) #14
f(malita)
On 2014/10/08 12:13:58, r.nagaraj wrote: > On 2014/10/08 12:06:16, Florin Malita wrote: > > LGTM, ...
6 years, 2 months ago (2014-10-08 12:29:11 UTC) #15
f(malita)
On 2014/10/08 12:29:11, Florin Malita wrote: > see codereview.chromium.org/617723003/ for an example) Ugh, wrong URL, ...
6 years, 2 months ago (2014-10-08 12:31:29 UTC) #16
robertphillips
I just checked and you aren't listed as an Authorized contributor in your company's Corporate ...
6 years, 2 months ago (2014-10-08 12:34:14 UTC) #17
RAGHURAM
On 2014/10/08 12:34:14, robertphillips wrote: > I just checked and you aren't listed as an ...
6 years, 2 months ago (2014-10-08 12:36:07 UTC) #18
RAGHURAM
On 2014/10/08 12:29:11, Florin Malita wrote: > On 2014/10/08 12:13:58, r.nagaraj wrote: > > On ...
6 years, 2 months ago (2014-10-09 05:37:49 UTC) #19
f(malita)
Thanks. LGTM.
6 years, 2 months ago (2014-10-09 12:18:16 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641523002/40001
6 years, 2 months ago (2014-10-09 12:20:02 UTC) #22
robertphillips
lgtm
6 years, 2 months ago (2014-10-09 12:20:21 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 60d943a787c49d4e605fe7df1229087cd71a815f
6 years, 2 months ago (2014-10-09 13:22:33 UTC) #24
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 13:23:15 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3c200fad33da10ca7b7bda1bba471d80ac570649
Cr-Commit-Position: refs/heads/master@{#298861}

Powered by Google App Engine
This is Rietveld 408576698