Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 641403002: Merge: Fix the filtering logic for x-chrome-manage-account header (Closed)

Created:
6 years, 2 months ago by guohui
Modified:
6 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2171
Project:
chromium
Visibility:
Public.

Description

Merge: Fix the filtering logic for x-chrome-manage-account header The current code checks if the request is loaded in a main frame and if it is triggered by a user gesture. As per discussion with eisinger@ there is no reliable way to associate a request with a user gesture, instead we should check if the requested resource type is a main frame resource. BUG=394869 TBR=guohui@chromium.org Review URL: https://codereview.chromium.org/632803002 Cr-Commit-Position: refs/heads/master@{#298372} (cherry picked from commit 564d209d5733494ca2847eef75161151e1dd0f24) Committed: https://chromium.googlesource.com/chromium/src/+/994f60059a7280d84e672a350f7525af0956c15e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/signin/signin_header_helper.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
guohui
6 years, 2 months ago (2014-10-10 17:41:47 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
994f60059a7280d84e672a350f7525af0956c15e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698