Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 632803002: Fix the filtering logic for x-chrome-manage-account header (Closed)

Created:
6 years, 2 months ago by guohui
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix the filtering logic for x-chrome-manage-account header The current code checks if the request is loaded in a main frame and if it is triggered by a user gesture. As per discussion with eisinger@ there is no reliable way to associate a request with a user gesture, instead we should check if the requested resource type is a main frame resource. BUG=394869 Committed: https://crrev.com/564d209d5733494ca2847eef75161151e1dd0f24 Cr-Commit-Position: refs/heads/master@{#298372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/signin/signin_header_helper.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
guohui
Hey Roger, could you please review the CL? Thanks, Hui
6 years, 2 months ago (2014-10-06 20:28:49 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm Might be able to remove include for page_transition_types.h
6 years, 2 months ago (2014-10-06 21:10:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/632803002/1
6 years, 2 months ago (2014-10-06 21:16:05 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-07 00:39:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/632803002/1
6 years, 2 months ago (2014-10-07 03:36:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as e981fc1419accdf5b043f41f2b9b7893c0c535ee
6 years, 2 months ago (2014-10-07 04:48:29 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 04:49:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/564d209d5733494ca2847eef75161151e1dd0f24
Cr-Commit-Position: refs/heads/master@{#298372}

Powered by Google App Engine
This is Rietveld 408576698