Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: chrome/common/extensions/api/extension_api_unittest.cc

Issue 641363003: Convert ARRAYSIZE_UNSAFE -> arraysize in chrome/, outside of chrome/browser/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/command_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/extension_api_unittest.cc
diff --git a/chrome/common/extensions/api/extension_api_unittest.cc b/chrome/common/extensions/api/extension_api_unittest.cc
index fdf1bc0f44779ac5497f50030c2c4bdc608ff69e..00a78a288affe1a90754c4f30bfe1c2e4dca77db 100644
--- a/chrome/common/extensions/api/extension_api_unittest.cc
+++ b/chrome/common/extensions/api/extension_api_unittest.cc
@@ -57,7 +57,7 @@ TEST(ExtensionAPITest, Creation) {
{ &empty_instance, false }
};
- for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data); ++i) {
+ for (size_t i = 0; i < arraysize(test_data); ++i) {
EXPECT_EQ(test_data[i].expect_populated,
test_data[i].api->GetSchema("bookmarks.create") != NULL);
}
@@ -75,7 +75,7 @@ TEST(ExtensionAPITest, SplitDependencyName) {
{"foo:bar", "foo", "bar"},
{"foo:bar.baz", "foo", "bar.baz"}};
- for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data); ++i) {
+ for (size_t i = 0; i < arraysize(test_data); ++i) {
std::string feature_type;
std::string feature_name;
ExtensionAPI::SplitDependencyName(
@@ -170,7 +170,7 @@ TEST(ExtensionAPITest, IsAvailableInUntrustedContextFeatures) {
scoped_refptr<Extension> extension =
BuildExtension(ExtensionBuilder().Pass()).Build();
- for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data); ++i) {
+ for (size_t i = 0; i < arraysize(test_data); ++i) {
ExtensionAPI api;
api.RegisterDependencyProvider("api", &api_feature_provider);
EXPECT_EQ(test_data[i].expect_is_available,
@@ -268,7 +268,7 @@ TEST(ExtensionAPITest, APIFeatures) {
base::JSONReader::Read(api_features_str)));
BaseFeatureProvider api_feature_provider(*value, CreateAPIFeature);
- for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data); ++i) {
+ for (size_t i = 0; i < arraysize(test_data); ++i) {
ExtensionAPI api;
api.RegisterDependencyProvider("api", &api_feature_provider);
for (base::DictionaryValue::Iterator iter(*value); !iter.IsAtEnd();
@@ -348,7 +348,7 @@ TEST(ExtensionAPITest, IsAnyFeatureAvailableToContext) {
base::JSONReader::Read(api_features_str)));
BaseFeatureProvider api_feature_provider(*value, CreateAPIFeature);
- for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data); ++i) {
+ for (size_t i = 0; i < arraysize(test_data); ++i) {
ExtensionAPI api;
api.RegisterDependencyProvider("api", &api_feature_provider);
for (base::DictionaryValue::Iterator iter(*value); !iter.IsAtEnd();
@@ -711,7 +711,7 @@ TEST(ExtensionAPITest, GetAPINameFromFullName) {
};
scoped_ptr<ExtensionAPI> api(ExtensionAPI::CreateWithDefaultConfiguration());
- for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data); ++i) {
+ for (size_t i = 0; i < arraysize(test_data); ++i) {
std::string child_name;
std::string api_name = api->GetAPINameFromFullName(test_data[i].input,
&child_name);
@@ -736,7 +736,7 @@ TEST(ExtensionAPITest, DefaultConfigurationFeatures) {
{ bookmarks_create }
};
- for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data); ++i) {
+ for (size_t i = 0; i < arraysize(test_data); ++i) {
SimpleFeature* feature = test_data[i].feature;
ASSERT_TRUE(feature) << i;
@@ -772,8 +772,7 @@ TEST(ExtensionAPITest, FeaturesRequireContexts) {
{ api_features2.get(), false }
};
-
- for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data); ++i) {
+ for (size_t i = 0; i < arraysize(test_data); ++i) {
BaseFeatureProvider api_feature_provider(*test_data[i].api_features,
CreateAPIFeature);
Feature* feature = api_feature_provider.GetFeature("test");
@@ -901,7 +900,7 @@ TEST(ExtensionAPITest, NoPermissions) {
scoped_refptr<Extension> extension =
BuildExtension(ExtensionBuilder().Pass()).Build();
- for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTests); ++i) {
+ for (size_t i = 0; i < arraysize(kTests); ++i) {
EXPECT_EQ(kTests[i].expect_success,
extension_api->IsAvailable(kTests[i].permission_name,
extension.get(),
« no previous file with comments | « no previous file | chrome/common/extensions/command_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698