chrome/common/extensions/command_unittest.cc - Issue 641363003: Convert ARRAYSIZE_UNSAFE -> arraysize in chrome/, outside of chrome/browser/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/command_unittest.cc

Issue 641363003: Convert ARRAYSIZE_UNSAFE -> arraysize in chrome/, outside of chrome/browser/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_api_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/command_unittest.cc

diff --git a/chrome/common/extensions/command_unittest.cc b/chrome/common/extensions/command_unittest.cc

index 795fb03f4f27d6855d23ac4acc445e3bfcac42d2..4a29ff8006334812ab54e101df94bf8c75cd19ab 100644

--- a/chrome/common/extensions/command_unittest.cc

+++ b/chrome/common/extensions/command_unittest.cc

@@ -191,7 +191,7 @@ TEST(CommandTest, ExtensionCommandParsing) {

all_platforms.push_back("mac");

all_platforms.push_back("windows");

- for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTests); ++i)

+ for (size_t i = 0; i < arraysize(kTests); ++i)

CheckParse(kTests[i], i, false, all_platforms);

}

@@ -293,7 +293,7 @@ TEST(CommandTest, ExtensionCommandParsingPlatformSpecific) {

std::vector<std::string> chromeos;

chromeos.push_back("chromeos");

- for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kChromeOsTests); ++i)

+ for (size_t i = 0; i < arraysize(kChromeOsTests); ++i)

CheckParse(kChromeOsTests[i], i, true, chromeos);

ConstCommandsTestData kNonChromeOsSearchTests[] = {

@@ -305,6 +305,6 @@ TEST(CommandTest, ExtensionCommandParsingPlatformSpecific) {

non_chromeos.push_back("mac");

non_chromeos.push_back("linux");

- for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kNonChromeOsSearchTests); ++i)

+ for (size_t i = 0; i < arraysize(kNonChromeOsSearchTests); ++i)

CheckParse(kNonChromeOsSearchTests[i], i, true, non_chromeos);

}