Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 641363003: Convert ARRAYSIZE_UNSAFE -> arraysize in chrome/, outside of chrome/browser/. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, skanuj+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, Ilya Sherman, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, benquan, rlp+watch_chromium.org, rouslan+autofillwatch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, dyu1, rouslan+spellwatch_chromium.org, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, Jered, tfarina, donnd+watch_chromium.org, David Black, Dane Wallinga, samarth+watch_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Convert ARRAYSIZE_UNSAFE -> arraysize in chrome/, outside of chrome/browser/. R=thestig@chromium.org BUG=423134 Committed: https://crrev.com/69be8769ba99c7cee59b32ec95ae4c7a4849e1a3 Cr-Commit-Position: refs/heads/master@{#299856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -55 lines) Patch
M chrome/common/extensions/api/extension_api_unittest.cc View 9 chunks +9 lines, -10 lines 0 comments Download
M chrome/common/extensions/command_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/x509_certificate_model_openssl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/variations/experiment_labels_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/web_apps_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/third_party/mozilla_security_manager/nsUsageArrayHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/convert_dict/convert_dict_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/tools/profile_reset/jtl_compiler_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/tools/profile_reset/jtl_parser_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/utility/importer/bookmarks_file_importer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/safari_importer_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 2 months ago (2014-10-16 03:17:53 UTC) #1
Lei Zhang
lgtm
6 years, 2 months ago (2014-10-16 05:53:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641363003/1
6 years, 2 months ago (2014-10-16 05:53:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 06:09:21 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 06:10:35 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/69be8769ba99c7cee59b32ec95ae4c7a4849e1a3
Cr-Commit-Position: refs/heads/master@{#299856}

Powered by Google App Engine
This is Rietveld 408576698