Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 641343002: Content Shell: Introduce LayoutTestBrowserContext. (Reland) (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Content Shell: Introduce LayoutTestBrowserContext. (Reland) This splits the DRT-specific parts of ShellBrowserContext out into a new class that we'll only instantiate when the flag is set. ------------------------------------------------------------------------ This is a re-land of https://codereview.chromium.org/637843003, which was reverted due to layout test timeouts. ------------------------------------------------------------------------ BUG=420994 Committed: https://crrev.com/d993d06a69153686d5a99c07d7825c5557a7ffd0 Cr-Commit-Position: refs/heads/master@{#299092}

Patch Set 1 #

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -18 lines) Patch
M content/content_shell.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A content/shell/browser/layout_test/layout_test_browser_context.h View 1 1 chunk +33 lines, -0 lines 0 comments Download
A content/shell/browser/layout_test/layout_test_browser_context.cc View 1 1 chunk +50 lines, -0 lines 0 comments Download
M content/shell/browser/shell_browser_context.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M content/shell/browser/shell_browser_context.cc View 1 3 chunks +4 lines, -12 lines 0 comments Download
M content/shell/browser/shell_browser_main_parts.cc View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Mike West
Vaclav pointed out to me that calling a virtual function from a constructor is a ...
6 years, 2 months ago (2014-10-10 10:41:18 UTC) #2
Mike West
apavlov: FYI, I'll probably be relanding this shortly. The blink bots are happy, so I ...
6 years, 2 months ago (2014-10-10 11:16:57 UTC) #4
vabr (Chromium)
The diff LGTM. Thanks! Vaclav
6 years, 2 months ago (2014-10-10 11:23:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641343002/160001
6 years, 2 months ago (2014-10-10 11:25:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:160001)
6 years, 2 months ago (2014-10-10 11:44:46 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 11:45:32 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d993d06a69153686d5a99c07d7825c5557a7ffd0
Cr-Commit-Position: refs/heads/master@{#299092}

Powered by Google App Engine
This is Rietveld 408576698