Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 637843003: Content Shell: Introduce LayoutTestBrowserContext. (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Content Shell: Introduce LayoutTestBrowserContext. This splits the DRT-specific parts of ShellBrowserContext out into a new class that we'll only instantiate when the flag is set. BUG=420994 Committed: https://crrev.com/98ce5ad6bdd2cd058c21f19b997032f3b958cb73 Cr-Commit-Position: refs/heads/master@{#299068}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -23 lines) Patch
M content/content_shell.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/shell/browser/layout_test/layout_test_browser_context.h View 1 chunk +37 lines, -0 lines 0 comments Download
A content/shell/browser/layout_test/layout_test_browser_context.cc View 1 chunk +54 lines, -0 lines 0 comments Download
M content/shell/browser/shell_browser_context.h View 1 1 chunk +6 lines, -7 lines 0 comments Download
M content/shell/browser/shell_browser_context.cc View 1 4 chunks +6 lines, -13 lines 0 comments Download
M content/shell/browser/shell_browser_main_parts.cc View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
Mike West
WDYT? -mike
6 years, 2 months ago (2014-10-09 11:48:28 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-09 13:16:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637843003/1
6 years, 2 months ago (2014-10-09 13:21:07 UTC) #5
commit-bot: I haz the power
Failed to apply patch for content/content_shell.gypi: While running git apply --index -3 -p1; error: patch ...
6 years, 2 months ago (2014-10-09 13:36:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637843003/20001
6 years, 2 months ago (2014-10-09 14:19:30 UTC) #10
commit-bot: I haz the power
Failed to commit the patch.
6 years, 2 months ago (2014-10-09 15:12:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637843003/20001
6 years, 2 months ago (2014-10-09 15:28:01 UTC) #15
commit-bot: I haz the power
Failed to commit the patch.
6 years, 2 months ago (2014-10-09 15:29:35 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637843003/20001
6 years, 2 months ago (2014-10-10 06:51:13 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-10 06:51:53 UTC) #21
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/98ce5ad6bdd2cd058c21f19b997032f3b958cb73 Cr-Commit-Position: refs/heads/master@{#299068}
6 years, 2 months ago (2014-10-10 06:52:30 UTC) #22
apavlov
6 years, 2 months ago (2014-10-10 08:23:23 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/641203004/ by apavlov@chromium.org.

The reason for reverting is: Tentatively resulted in multiple layout test
timeouts across the chromium.webkit waterfall..

Powered by Google App Engine
This is Rietveld 408576698