Issue 6413031: Merge 73784 - Reland r73760: Move most of chrome-extension:// request...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6413031: Merge 73784 - Reland r73760: Move most of chrome-extension:// request... (Closed)

Created:
9 years, 10 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, vrk (LEFT CHROMIUM), sjl, ddorwin+watch_chromium.org, Erik does not do reviews, Alpha Left Google, brettw-cc_chromium.org, Aaron Boodman, acolwell GONE FROM CHROMIUM, annacc, pam+watch_chromium.org, awong, Paweł Hajdan Jr., darin-cc_chromium.org, scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/branches/648/src/

Visibility:
Public.

Description

Merge 73784 - Reland r73760: Move most of chrome-extension:// request checks into renderer. One cannot be moved because we don't have the bit of state we need in the renderer. This should have fixed the bug 57263, but it doesn't. So maybe something else is going on? BUG=57263 TBR=mpcomplete@chromium.org TBR=aa@chromium.org

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -170 lines)			Patch
M	chrome/browser/extensions/extension_apitest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_browsertests_misc.cc	View	1 chunk	+0 lines, -66 lines	0 comments	Download
M	chrome/browser/extensions/extension_protocols.cc	View	4 chunks	+6 lines, -46 lines	0 comments	Download
A +	chrome/browser/extensions/extension_resource_request_policy_apitest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_renderer.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	chrome/renderer/extensions/extension_resource_request_policy.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/renderer/extensions/extension_resource_request_policy.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	2 chunks	+14 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/extension/manifest.json	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/extension/test.png	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/extension2/can_load_icons_from_hosted_apps.html	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/extension2/cant_load_packaged_resources_from_hosted_apps.html	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/extension2/extensions_can_load_other_extension_resources.html	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/extension2/index.html	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/extension2/manifest.json	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/extension2/test.png	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/hosted_app/manifest.json	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/hosted_app/test.png	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/hosted_app/test2.png	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/index.html	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/media/audio.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/media/bear.wav	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/media/bear.webm	View	Binary file		0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/media/manifest.json	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/extension_resource_request_policy/media/video.html	View	1 chunk	+3 lines, -0 lines	0 comments	Download
D	chrome/test/data/extensions/origin_privileges/extension/manifest.json	View	1 chunk	+0 lines, -7 lines	0 comments	Download
D	chrome/test/data/extensions/origin_privileges/extension/test.png	View	Binary file		0 comments	Download
D	chrome/test/data/extensions/origin_privileges/extension2/can_load_icons_from_hosted_apps.html	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	chrome/test/data/extensions/origin_privileges/extension2/cant_load_packaged_resources_from_hosted_apps.html	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	chrome/test/data/extensions/origin_privileges/extension2/extensions_can_load_other_extension_resources.html	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	chrome/test/data/extensions/origin_privileges/extension2/index.html	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	chrome/test/data/extensions/origin_privileges/extension2/manifest.json	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	chrome/test/data/extensions/origin_privileges/extension2/test.png	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	chrome/test/data/extensions/origin_privileges/hosted_app/manifest.json	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	chrome/test/data/extensions/origin_privileges/hosted_app/test.png	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	chrome/test/data/extensions/origin_privileges/hosted_app/test2.png	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	chrome/test/data/extensions/origin_privileges/index.html	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages