Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5776)

Unified Diff: chrome/renderer/render_view.cc

Issue 6413031: Merge 73784 - Reland r73760: Move most of chrome-extension:// request... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/648/src/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/render_view.cc
===================================================================
--- chrome/renderer/render_view.cc (revision 74048)
+++ chrome/renderer/render_view.cc (working copy)
@@ -57,6 +57,7 @@
#include "chrome/renderer/extensions/event_bindings.h"
#include "chrome/renderer/extensions/extension_process_bindings.h"
#include "chrome/renderer/extensions/extension_renderer_info.h"
+#include "chrome/renderer/extensions/extension_resource_request_policy.h"
#include "chrome/renderer/extensions/renderer_extension_bindings.h"
#include "chrome/renderer/external_host_bindings.h"
#include "chrome/renderer/external_popup_menu.h"
@@ -3571,6 +3572,19 @@
WebDataSource* top_data_source = top_frame->dataSource();
WebDataSource* data_source =
provisional_data_source ? provisional_data_source : top_data_source;
+
+ // If the request is for an extension resource, check whether it should be
+ // allowed. If not allowed, we reset the URL to something invalid to prevent
+ // the request and cause an error.
+ GURL request_url(request.url());
+ if (request_url.SchemeIs(chrome::kExtensionScheme) &&
+ !ExtensionResourceRequestPolicy::CanRequestResource(
+ request_url,
+ GURL(frame->url()),
+ render_thread_->GetExtensions())) {
+ request.setURL(WebURL(GURL("chrome-extension://invalid/")));
+ }
+
if (data_source) {
NavigationState* state = NavigationState::FromDataSource(data_source);
if (state && state->is_cache_policy_override_set())

Powered by Google App Engine
This is Rietveld 408576698