Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 641113004: ozone: evdev: Factor keyboard into KeyboardEvdev (Closed)

Created:
6 years, 2 months ago by spang
Modified:
6 years, 2 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Factor keyboard into KeyboardEvdev This object is responsible for combining all attached keyboards into one logical keyboard, applying modifiers & implementing key repeat. Key repeat is not done yet. We need this so we can also dispatch keypresses from gestures devices (e.g. Logitech K400). BUG=412996 TEST=events_unittests, link_freon Committed: https://crrev.com/97f2fd7b28f26d510cc3bd6adf92da8bc50be81d Cr-Commit-Position: refs/heads/master@{#300270}

Patch Set 1 #

Total comments: 2

Patch Set 2 : std::bitset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -338 lines) Patch
M ui/events/ozone/evdev/event_factory_evdev.h View 2 chunks +7 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/key_event_converter_evdev.h View 3 chunks +4 lines, -9 lines 0 comments Download
M ui/events/ozone/evdev/key_event_converter_evdev.cc View 2 chunks +6 lines, -207 lines 0 comments Download
M ui/events/ozone/evdev/key_event_converter_evdev_unittest.cc View 9 chunks +62 lines, -58 lines 0 comments Download
A ui/events/ozone/evdev/keyboard_evdev.h View 1 1 chunk +60 lines, -0 lines 0 comments Download
A + ui/events/ozone/evdev/keyboard_evdev.cc View 1 4 chunks +34 lines, -58 lines 0 comments Download
M ui/events/ozone/events_ozone.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
spang
6 years, 2 months ago (2014-10-09 20:13:58 UTC) #2
spang
on top of https://codereview.chromium.org/645673003/
6 years, 2 months ago (2014-10-09 20:14:34 UTC) #3
kpschoedel
https://codereview.chromium.org/641113004/diff/1/ui/events/ozone/evdev/keyboard_evdev.h File ui/events/ozone/evdev/keyboard_evdev.h (right): https://codereview.chromium.org/641113004/diff/1/ui/events/ozone/evdev/keyboard_evdev.h#newcode46 ui/events/ozone/evdev/keyboard_evdev.h:46: unsigned long key_state_[EVDEV_BITS_TO_LONGS(KEY_CNT)]; Why not use std::bitset?
6 years, 2 months ago (2014-10-09 22:51:10 UTC) #4
spang
https://codereview.chromium.org/641113004/diff/1/ui/events/ozone/evdev/keyboard_evdev.h File ui/events/ozone/evdev/keyboard_evdev.h (right): https://codereview.chromium.org/641113004/diff/1/ui/events/ozone/evdev/keyboard_evdev.h#newcode46 ui/events/ozone/evdev/keyboard_evdev.h:46: unsigned long key_state_[EVDEV_BITS_TO_LONGS(KEY_CNT)]; On 2014/10/09 22:51:09, kpschoedel wrote: > ...
6 years, 2 months ago (2014-10-14 16:02:09 UTC) #5
kpschoedel
lgtm
6 years, 2 months ago (2014-10-14 16:06:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641113004/230001
6 years, 2 months ago (2014-10-14 19:23:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641113004/230001
6 years, 2 months ago (2014-10-20 15:37:00 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:230001)
6 years, 2 months ago (2014-10-20 15:40:04 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 15:40:59 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/97f2fd7b28f26d510cc3bd6adf92da8bc50be81d
Cr-Commit-Position: refs/heads/master@{#300270}

Powered by Google App Engine
This is Rietveld 408576698