Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 641083002: Propagate error/exception information for rejected Promises in Service workers. (Closed)

Created:
6 years, 2 months ago by Mayur Kankanwadi
Modified:
6 years, 1 month ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, dominicc (has gone to gerrit)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Propagate error/exception information for rejected Promises in Service workers. This CL implements the part of reporting rejected promises. Error information is passed on to WorkerReportingProxy? to propagate it to the browser. BUG=359423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -8 lines) Patch
M Source/modules/serviceworkers/RespondWithObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.cpp View 5 chunks +26 lines, -5 lines 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.cpp View 2 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dominicc (has gone to gerrit)
6 years, 2 months ago (2014-10-23 05:25:31 UTC) #2
Not LGTM.

I don't think this is the right approach. Your example on the bug doesn't work
because the Promise is rejected with an Error but your C++ code looks for
ErrorEvent. Promises could be rejected with anything.

We need callstacks and line numbers for reporting. Strings and Errors that
weren't caught don't have stack traces. This callback is too late to build a
stack trace because I believe the script is done executing.

I think we should hook into V8's rejected Promise reporting infrastructure.

Powered by Google App Engine
This is Rietveld 408576698