Make "InsertHTML" and "Indent" commands to handle DOM tree modification during processing

Make "InsertHTML" and "Indent" commands to handle DOM tree modification during processing

This patch makes "InsertHTML" and "Indent" commands to handle DOM tree modification during processing. When calling Node::insertBefore(), JavaScript may be executed, e.g. <iframe src="javascript:...">, and it modifies DOM tree.

On issue 314469, use-after-free is caused at |startBlock| variable which holds raw Node pointer removed during script execution in ReplaceSelectionCommand::doApply().

Changes for CompositeEditCommand::cloneParagraphUnderNewElement() is similar to ReplaceSelectionCommand::doApply(). |outerNode| is removed during CompositeEditCommand::appendNode(), which inserts <iframe src="javascript:...">.

BUG=314469
TEST=LayoutTests/editing/inserting/insert-with-javascript-protocol-crash.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161598

[yosin_UTC9, 2013-11-08 05:10:42]

Could you review this patch?
Thanks in advance.
-yosi

P.S. Mac bot failure doesn't relate to this patch.

[tkent, 2013-11-08 05:16:46]

lgtm

[commit-bot: I haz the power, 2013-11-08 05:47:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yosin@chromium.org/64103002/40001

[commit-bot: I haz the power, 2013-11-08 07:02:16]

Retried try job too often on linux_blink_rel for step(s) weborigin_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2013-11-08 08:07:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yosin@chromium.org/64103002/40001

[commit-bot: I haz the power, 2013-11-08 09:17:32]

Retried try job too often on linux_blink_rel for step(s) weborigin_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2013-11-08 09:25:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yosin@chromium.org/64103002/40001

[commit-bot: I haz the power, 2013-11-08 10:03:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yosin@chromium.org/64103002/40001

[commit-bot: I haz the power, 2013-11-08 10:06:20]

Change committed as 161598