Source/core/editing/CompositeEditCommand.cpp - Issue 64103002: Make "InsertHTML" and "Indent" commands to handle DOM tree modification during processing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/CompositeEditCommand.cpp

Issue 64103002: Make "InsertHTML" and "Indent" commands to handle DOM tree modification during processing (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: 2013-11-08T13:02:58 Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/editing/inserting/insert-with-javascript-protocol-crash-expected.txt ('k') | Source/core/editing/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/CompositeEditCommand.cpp

diff --git a/Source/core/editing/CompositeEditCommand.cpp b/Source/core/editing/CompositeEditCommand.cpp

index ae7cebfceb0bea5a4f958b37bce6d3728d014522..d72e31c4f85cbfc478296ea131696222dcb9b99f 100644

--- a/Source/core/editing/CompositeEditCommand.cpp

+++ b/Source/core/editing/CompositeEditCommand.cpp

@@ -998,6 +998,11 @@ void CompositeEditCommand::cloneParagraphUnderNewElement(Position& start, Positi

}

+ // Scripts specified in javascript protocol may remove |outerNode|

+ // during insertion, e.g. <iframe src="javascript:...">

+ if (!outerNode->inDocument())

+ return;

// Handle the case of paragraphs with more than one node,

// cloning all the siblings until end.deprecatedNode() is reached.