Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 6410134: Use named automation interface to control primary chrome on ChromeOS (Closed)

Created:
9 years, 10 months ago by Nirnimesh
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone, oshima, zel
CC:
chromium-reviews, John Grabowski, jam, anantha, darin-cc_chromium.org, dyu1, Paweł Hajdan Jr., pam+watch_chromium.org, dtu, krisr
Visibility:
Public.

Description

Use named automation interface to control the primary chrome to run pyauto-based chrome tests on ChromeOS. This CL includes: - enable_testing.py -- sends dbus call to session_manager to enable testing interface - pyauto.py -- integration of named automation interface with PyAuto - desktopui_PyAutoFunctionalTests.py -- setup to use named automation interface. Uses a suid-root binary (as discussed with cmasone) to dbus mesg to session_manager - PYAUTO_TESTS -- a new suite called "PRIMARY_CHROME" which currently consists of a basic hello world test that controls the primary chrome - chromeos_basic.py -- a basic test All plumbing necessary to integrate the named automation interface with autotest and pyauto is included. It's designed such that it's easy to work directly on a chromeos device while adding/editing a pyauto test, without having to run via autotest every time. Also, the existing pyauto tests (about 200 of them) will begin controlling the primary chrome. Can be run with run_remote_tests.sh as: $ ./run_remote_tests.sh --remote <IP> desktopui_PyAutoFunctionalTests BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75797

Patch Set 1 #

Patch Set 2 : can login #

Patch Set 3 : use autotest $default account #

Patch Set 4 : nit #

Total comments: 6

Patch Set 5 : cmasone #

Patch Set 6 : ws #

Patch Set 7 : ws #

Patch Set 8 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -17 lines) Patch
M chrome/test/chromeos/autotest/files/client/site_tests/desktopui_PyAutoFunctionalTests/desktopui_PyAutoFunctionalTests.py View 1 2 3 4 5 6 7 1 chunk +49 lines, -6 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 1 2 1 chunk +22 lines, -1 line 0 comments Download
A chrome/test/functional/chromeos_basic.py View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/test/pyautolib/chromeos/chromeos_utils.py View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/test/pyautolib/chromeos/enable_testing.py View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 2 3 4 5 6 6 chunks +90 lines, -1 line 0 comments Download
M chrome/test/pyautolib/pyautolib.h View 3 chunks +13 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.cc View 2 chunks +16 lines, -6 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.i View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Nirnimesh
I'm adding only one test to begin with for the named automation interface. I'll migrate ...
9 years, 10 months ago (2011-02-19 00:29:55 UTC) #1
Chris Masone
http://codereview.chromium.org/6410134/diff/11001/chrome/test/chromeos/autotest/files/client/site_tests/desktopui_PyAutoFunctionalTests/desktopui_PyAutoFunctionalTests.py File chrome/test/chromeos/autotest/files/client/site_tests/desktopui_PyAutoFunctionalTests/desktopui_PyAutoFunctionalTests.py (right): http://codereview.chromium.org/6410134/diff/11001/chrome/test/chromeos/autotest/files/client/site_tests/desktopui_PyAutoFunctionalTests/desktopui_PyAutoFunctionalTests.py#newcode33 chrome/test/chromeos/autotest/files/client/site_tests/desktopui_PyAutoFunctionalTests/desktopui_PyAutoFunctionalTests.py:33: shutil.copy('/usr/local/bin/python2.6', suid_python) Shouldn't this copy of python be deleted ...
9 years, 10 months ago (2011-02-22 15:58:41 UTC) #2
Nirnimesh
http://codereview.chromium.org/6410134/diff/11001/chrome/test/chromeos/autotest/files/client/site_tests/desktopui_PyAutoFunctionalTests/desktopui_PyAutoFunctionalTests.py File chrome/test/chromeos/autotest/files/client/site_tests/desktopui_PyAutoFunctionalTests/desktopui_PyAutoFunctionalTests.py (right): http://codereview.chromium.org/6410134/diff/11001/chrome/test/chromeos/autotest/files/client/site_tests/desktopui_PyAutoFunctionalTests/desktopui_PyAutoFunctionalTests.py#newcode33 chrome/test/chromeos/autotest/files/client/site_tests/desktopui_PyAutoFunctionalTests/desktopui_PyAutoFunctionalTests.py:33: shutil.copy('/usr/local/bin/python2.6', suid_python) On 2011/02/22 15:58:41, Chris Masone wrote: > ...
9 years, 10 months ago (2011-02-22 22:17:18 UTC) #3
Chris Masone
LGTM, then, but zel should still look at this.
9 years, 10 months ago (2011-02-22 22:53:54 UTC) #4
Nirnimesh
+oshima, as Zel suggested.
9 years, 10 months ago (2011-02-23 01:45:50 UTC) #5
zel
LGTM ...sorry for the delay
9 years, 10 months ago (2011-02-23 19:40:22 UTC) #6
oshima
Do you still need my review? - oshima On Tue, Feb 22, 2011 at 5:45 ...
9 years, 10 months ago (2011-02-24 20:37:19 UTC) #7
Nirnimesh
9 years, 10 months ago (2011-02-24 20:39:59 UTC) #8
On 2011/02/24 20:37:19, oshima wrote:
> Do you still need my review?

Zel got to it. Thanks

Powered by Google App Engine
This is Rietveld 408576698