Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(814)

Issue 6410125: Extend Mac popup to handle more directionality.... (Closed)

Created:
8 years, 11 months ago by Avi (use Gerrit)
Modified:
8 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Extend Mac popup to handle more directionality. BUG=71326 TEST=verify popup is correct with test page noted in bug writeup. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74622

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -86 lines) Patch
M chrome/common/render_messages.cc View 3 chunks +12 lines, -4 lines 0 comments Download
M webkit/glue/webmenuitem.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/webmenuitem.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M webkit/glue/webmenurunner_mac.h View 2 chunks +4 lines, -1 line 0 comments Download
M webkit/glue/webmenurunner_mac.mm View 5 chunks +78 lines, -81 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
Notes: - This will require the landing of the WebKit side of the patch first. ...
8 years, 11 months ago (2011-02-07 21:19:34 UTC) #1
Mark Mentovai
8 years, 11 months ago (2011-02-07 21:35:51 UTC) #2
Looks like it’ll work. LGTM.

Powered by Google App Engine
This is Rietveld 408576698