run iwyu on base!

run iwyu on base!

(on os x)

In general, follow http://code.google.com/p/include-what-you-use/wiki/InstructionsForUsers

You need to build with `make REQUIRES_RTTI=1`

Build base like this:
    cd base
    xcodebuild -target base CC=/Users/thakis/src/llvm-svn/Release+Asserts/bin/include-what-you-use 2>&1 | tee iwyuout.txt
    python ../../../llvm-svn/tools/clang/tools/include-what-you-use/fix_includes.py --blank_lines --nocomments < iwyuout.txt 

iwyu gets confused because the cwd isn't the source root. I hacked around this with this iwyu patch:
hummer:include-what-you-use thakis$ svn diff
Index: iwyu_include_picker.cc
===================================================================
--- iwyu_include_picker.cc	(revision 15)
+++ iwyu_include_picker.cc	(working copy)
@@ -963,7 +963,7 @@
   *path = NormalizeFilePath(*path);
 
   // Case 1: a local (non-system) include.
-if (!StartsWith(*path, "/")) {  // A relative path
+  if (!StartsWith(*path, "/")) {  // A relative path
     *include_map = StartsWith(*path, "third_party/") ?
         &third_party_include_map_ : &google_include_map_;
   } else if (StripPast(path, "/c++/") && StripPast(path, "/")) {
Index: iwyu_location_util.h
===================================================================
--- iwyu_location_util.h	(revision 15)
+++ iwyu_location_util.h	(working copy)
@@ -78,8 +78,11 @@
 }
 
 inline string GetFilePath(const clang::FileEntry* file) {
-  return (IsBuiltinFile(file) ? "<built-in>" :
+  string result = (IsBuiltinFile(file) ? "<built-in>" :
           NormalizeFilePath(file->getName()));
+  if (result.size () > 3 && result[0] == '.' && result[1] == '.' && result[2] == '/')
+    result = result.substr(3);
+  return result;
 }
 
 //------------------------------------------------------------


Stuff like #include </Developer/SDKs/MacOSX10.5.sdk/System/Library/Frameworks/Security.framework/Headers/cssmtype.h> shows that the iwyu header maps need some updating on OS X (I don't fully grok the iwyu code yet)


With this patch, base has 8 build errors: http://codepad.org/HWHJ8fou


106 files changed, 669 insertions(+), 334 deletions(-)