Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 640813003: Oilpan: fix build after r183834. (Closed)

Created:
6 years, 2 months ago by sof
Modified:
6 years, 2 months ago
CC:
blink-reviews, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r183834. TBR=oilpan-reviews,haraken BUG=423536 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183837

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 7 (2 generated)
sof
Please take a look.
6 years, 2 months ago (2014-10-16 21:17:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640813003/1
6 years, 2 months ago (2014-10-16 21:19:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 183837
6 years, 2 months ago (2014-10-16 21:19:56 UTC) #4
dcheng
https://codereview.chromium.org/640813003/diff/1/Source/web/tests/WebFrameTest.cpp File Source/web/tests/WebFrameTest.cpp (right): https://codereview.chromium.org/640813003/diff/1/Source/web/tests/WebFrameTest.cpp#newcode6522 Source/web/tests/WebFrameTest.cpp:6522: RefPtrWillBePersistent<Frame> childCoreFrame = toCoreFrame(childFrame); Why not RefPtrWillBeRaw? This is ...
6 years, 2 months ago (2014-10-16 21:25:42 UTC) #6
haraken
6 years, 2 months ago (2014-10-16 23:19:10 UTC) #7
Message was sent while issue was closed.
LGTM

https://codereview.chromium.org/640813003/diff/1/Source/web/tests/WebFrameTes...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/640813003/diff/1/Source/web/tests/WebFrameTes...
Source/web/tests/WebFrameTest.cpp:6522: RefPtrWillBePersistent<Frame>
childCoreFrame = toCoreFrame(childFrame);
On 2014/10/16 21:25:42, dcheng wrote:
> Why not RefPtrWillBeRaw? This is a stack pointer.

In this case RefPtrWillBeRawPtr is fine, but we prefer using
RefPtrWillBePersistent in tests because we sometimes have the following code:

RefPtrWillBePersistent<X> x = ...;
Heap::collectAllGarbage();  // Run a precise GC (which assumes that there is no
stack pointer) to collect all objects reliably.
...;  // Test that some object is gone.

Powered by Google App Engine
This is Rietveld 408576698