Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 640813003: Oilpan: fix build after r183834. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp
index 87d74a5f2fb5832e82e3a9889e394f5c1f40a29b..ff83e838edc7edd9794e34cf0e2496a828d03e3a 100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -6519,7 +6519,7 @@ TEST_F(WebFrameTest, EmbedderTriggeredDetachWithRemoteMainFrame)
WebLocalFrame* childFrame = view->mainFrame()->toWebRemoteFrame()->createLocalChild("", &childFrameClient);
// Purposely keep the LocalFrame alive so it's the last thing to be destroyed.
- RefPtr<Frame> childCoreFrame = toCoreFrame(childFrame);
+ RefPtrWillBePersistent<Frame> childCoreFrame = toCoreFrame(childFrame);
dcheng 2014/10/16 21:25:42 Why not RefPtrWillBeRaw? This is a stack pointer.
haraken 2014/10/16 23:19:10 In this case RefPtrWillBeRawPtr is fine, but we pr
view->close();
childCoreFrame.clear();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698