Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 640773004: Add clip to layer cache (Closed)

Created:
6 years, 2 months ago by robertphillips
Modified:
6 years, 2 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add clip to layer cache This CL adds the clip region to the GPU layer hoisting image cache. It also switches back to the old caching behavior of using the entire CTM in the cache key rather then just the upper 2x2. This latter change is to focus more on hoisting rather then caching. It also includes 2 smaller fixes: a) layer's that have an image filter are no longer atlased (b.c. doing so complicates applying the image filter) b) the result of clipping the layer's bounds to the current clip is used as the hoisted layer's size. This reduces the amount of pixels drawn to match a normal (non-hoisted) draw pass. Committed: https://skia.googlesource.com/skia/+/3aac6e0848010efe046bd86bcb341dad5a23e174

Patch Set 1 #

Patch Set 2 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -86 lines) Patch
M src/gpu/GrLayerCache.h View 5 chunks +24 lines, -14 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 2 chunks +8 lines, -9 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 1 7 chunks +20 lines, -14 lines 0 comments Download
M src/gpu/GrPictureUtils.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/gpu/GrPictureUtils.cpp View 1 3 chunks +9 lines, -12 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 5 chunks +13 lines, -7 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +25 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
robertphillips
6 years, 2 months ago (2014-10-20 14:50:25 UTC) #2
jvanverth1
lgtm
6 years, 2 months ago (2014-10-20 15:43:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640773004/20001
6 years, 2 months ago (2014-10-20 15:45:03 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 15:52:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 3aac6e0848010efe046bd86bcb341dad5a23e174

Powered by Google App Engine
This is Rietveld 408576698