Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 640633007: DevTools: fix "Disable Javascript" checkbox glitch. (Closed)

Created:
6 years, 2 months ago by eustas
Modified:
6 years, 2 months ago
Reviewers:
vsevik, apavlov, aandrey
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git/+/master
Project:
blink
Visibility:
Public.

Description

DevTools: fix "Disable Javascript" checkbox glitch. Settings checkbox UI state was changed from outside, that confused control. BUG=402406 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183880

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/devtools/front_end/sources/SourcesPanel.js View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 9 (3 generated)
eustas
6 years, 2 months ago (2014-10-17 09:06:21 UTC) #2
vsevik
lgtm
6 years, 2 months ago (2014-10-17 09:25:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640633007/1
6 years, 2 months ago (2014-10-17 09:26:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 183880
6 years, 2 months ago (2014-10-17 11:00:21 UTC) #6
aandrey
https://codereview.chromium.org/640633007/diff/1/Source/devtools/front_end/sources/SourcesPanel.js File Source/devtools/front_end/sources/SourcesPanel.js (right): https://codereview.chromium.org/640633007/diff/1/Source/devtools/front_end/sources/SourcesPanel.js#newcode1354 Source/devtools/front_end/sources/SourcesPanel.js:1354: WebInspector.settings.javaScriptDisabled.set(disabled); don't you still need to update this._disableJSCheckbox.checked ?
6 years, 2 months ago (2014-10-17 12:11:51 UTC) #8
eustas
6 years, 2 months ago (2014-10-17 12:16:11 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/640633007/diff/1/Source/devtools/front_end/so...
File Source/devtools/front_end/sources/SourcesPanel.js (right):

https://codereview.chromium.org/640633007/diff/1/Source/devtools/front_end/so...
Source/devtools/front_end/sources/SourcesPanel.js:1354:
WebInspector.settings.javaScriptDisabled.set(disabled);
On 2014/10/17 12:11:51, aandrey wrote:
> don't you still need to update this._disableJSCheckbox.checked ?

Nope. setting change is listened by checkbox itself.

Powered by Google App Engine
This is Rietveld 408576698