Source/devtools/front_end/sources/SourcesPanel.js - Issue 640633007: DevTools: fix "Disable Javascript" checkbox glitch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sources/SourcesPanel.js

Issue 640633007: DevTools: fix "Disable Javascript" checkbox glitch. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/sources/SourcesPanel.js

diff --git a/Source/devtools/front_end/sources/SourcesPanel.js b/Source/devtools/front_end/sources/SourcesPanel.js

index 9036c4d4318430ab1c161c1bb9f4c1d83bec75c3..e7447a7112bb4af60f4cddb608e5dc80ba4cd31a 100644

--- a/Source/devtools/front_end/sources/SourcesPanel.js

+++ b/Source/devtools/front_end/sources/SourcesPanel.js

@@ -1349,8 +1349,9 @@ WebInspector.SourcesPanel.DisableJavaScriptSettingDelegate.prototype = {

var disabled = forbidden || (status === "disabled");

this._disableJSInfo.classList.toggle("hidden", !forbidden);

- this._disableJSCheckbox.checked = disabled;

this._disableJSCheckbox.disabled = forbidden;

+ if (!forbidden && WebInspector.settings.javaScriptDisabled.get() !== disabled)

+ WebInspector.settings.javaScriptDisabled.set(disabled);

aandrey 2014/10/17 12:11:51 don't you still need to update this._disableJSChec

eustas 2014/10/17 12:16:11 Nope. setting change is listened by checkbox itsel

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »