Create a cross-platform browsertest for the browser actions bar

Create a cross-platform browsertest for the browser actions bar

Move the setup from BrowserActionsContainerTest into a
platform-independent test, so that we also start to get
test coverage on Mac.  In this first patch, move the
infrastructure and the basic test.  More to follow.

BUG=422381
Committed: https://crrev.com/88a5d47e8eb951cae8a1f6e492b1400467e4178b
Cr-Commit-Position: refs/heads/master@{#299313}

[Devlin, 2014-10-10 15:36:25]

Patchset #1 (id:1) has been deleted

[Devlin, 2014-10-10 15:36:32]

Patchset #1 (id:100001) has been deleted

[Devlin, 2014-10-10 15:36:37]

Patchset #1 (id:130001) has been deleted

[Devlin, 2014-10-10 17:12:05]

Patchset #1 (id:160001) has been deleted

[Devlin, 2014-10-10 17:12:22]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org, pkasting@chromium.org

[Peter Kasting, 2014-10-10 20:32:51]

LGTM

https://codereview.chromium.org/640423003/diff/240001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc (right):

https://codereview.chromium.org/640423003/diff/240001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc:16: using
extensions::Extension;
Nit: Avoid using directives unless they significantly enhance readability.  In
your case I think you only even use Extension once, so don't do this.

https://codereview.chromium.org/640423003/diff/240001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h (right):

https://codereview.chromium.org/640423003/diff/240001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h:54: };
Nit: DISALLOW_COPY_AND_ASSIGN

https://codereview.chromium.org/640423003/diff/240001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
(right):

https://codereview.chromium.org/640423003/diff/240001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc:326: //
Force hide one of the extension's browser action.
Nit: extensions'

[Devlin, 2014-10-10 20:40:23]

https://codereview.chromium.org/640423003/diff/240001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc (right):

https://codereview.chromium.org/640423003/diff/240001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc:16: using
extensions::Extension;
On 2014/10/10 20:32:51, Peter Kasting wrote:
> Nit: Avoid using directives unless they significantly enhance readability.  In
> your case I think you only even use Extension once, so don't do this.

Whoops, sorry.  Copy and paste from other file that I forgot to remove.
Done, and also removed from browser_actions_container_browsertest.cc.

https://codereview.chromium.org/640423003/diff/240001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h (right):

https://codereview.chromium.org/640423003/diff/240001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h:54: };
On 2014/10/10 20:32:51, Peter Kasting wrote:
> Nit: DISALLOW_COPY_AND_ASSIGN

Done.

https://codereview.chromium.org/640423003/diff/240001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
(right):

https://codereview.chromium.org/640423003/diff/240001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc:326: //
Force hide one of the extension's browser action.
On 2014/10/10 20:32:51, Peter Kasting wrote:
> Nit: extensions'

Done.

[Finnur, 2014-10-13 12:56:36]

Excellent!

LGTM.

[Devlin, 2014-10-13 15:58:22]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org

[Devlin, 2014-10-13 15:58:23]

Avi, mind taking a quick look at the cocoa?

[Avi (use Gerrit), 2014-10-13 16:31:52]

Cocoa stuff LGTM

[Devlin, 2014-10-13 16:33:31]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-10-13 16:34:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/640423003/390001

[commit-bot: I haz the power, 2014-10-13 17:27:37]

Committed patchset #2 (id:390001)

[commit-bot: I haz the power, 2014-10-13 17:28:46]

Patchset 2 (id:??) landed as
https://crrev.com/88a5d47e8eb951cae8a1f6e492b1400467e4178b
Cr-Commit-Position: refs/heads/master@{#299313}