Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc

Issue 640423003: Create a cross-platform browsertest for the browser actions bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Peter's Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h"
6
7 #include "chrome/browser/extensions/browser_action_test_util.h"
8 #include "chrome/browser/extensions/extension_browsertest.h"
9 #include "chrome/browser/extensions/extension_service.h"
10 #include "components/crx_file/id_util.h"
11 #include "extensions/browser/extension_registry.h"
12 #include "extensions/common/extension.h"
13 #include "extensions/common/extension_builder.h"
14 #include "extensions/common/value_builder.h"
15
16 namespace {
17
18 scoped_refptr<const extensions::Extension> CreateExtension(
19 const std::string& name,
20 bool has_browser_action) {
21 extensions::DictionaryBuilder manifest;
22 manifest.Set("name", name).
23 Set("description", "an extension").
24 Set("manifest_version", 2).
25 Set("version", "1.0");
26 if (has_browser_action)
27 manifest.Set("browser_action", extensions::DictionaryBuilder().Pass());
28 return extensions::ExtensionBuilder().
29 SetManifest(manifest.Pass()).
30 SetID(crx_file::id_util::GenerateId(name)).
31 Build();
32 }
33
34 } // namespace
35
36 BrowserActionsBarBrowserTest::BrowserActionsBarBrowserTest() {
37 }
38
39 BrowserActionsBarBrowserTest::~BrowserActionsBarBrowserTest() {
40 }
41
42 void BrowserActionsBarBrowserTest::SetUpCommandLine(
43 base::CommandLine* command_line) {
44 BrowserActionTestUtil::DisableAnimations();
45 ExtensionBrowserTest::SetUpCommandLine(command_line);
46 }
47
48 void BrowserActionsBarBrowserTest::SetUpOnMainThread() {
49 ExtensionBrowserTest::SetUpOnMainThread();
50 browser_actions_bar_.reset(new BrowserActionTestUtil(browser()));
51 }
52
53 void BrowserActionsBarBrowserTest::TearDownOnMainThread() {
54 BrowserActionTestUtil::EnableAnimations();
55 ExtensionBrowserTest::TearDownOnMainThread();
56 }
57
58 void BrowserActionsBarBrowserTest::LoadExtensions() {
59 // Create three extensions with browser actions.
60 extension_a_ = CreateExtension("alpha", true);
61 extension_b_ = CreateExtension("beta", true);
62 extension_c_ = CreateExtension("gamma", true);
63
64 const extensions::Extension* extensions[] =
65 { extension_a(), extension_b(), extension_c() };
66 extensions::ExtensionRegistry* registry =
67 extensions::ExtensionRegistry::Get(profile());
68 // Add each, and verify that it is both correctly added to the extension
69 // registry and to the browser actions container.
70 for (size_t i = 0; i < arraysize(extensions); ++i) {
71 extension_service()->AddExtension(extensions[i]);
72 EXPECT_TRUE(registry->enabled_extensions().GetByID(extensions[i]->id())) <<
73 extensions[i]->name();
74 EXPECT_EQ(static_cast<int>(i + 1),
75 browser_actions_bar_->NumberOfBrowserActions());
76 EXPECT_TRUE(browser_actions_bar_->HasIcon(i));
77 EXPECT_EQ(static_cast<int>(i + 1),
78 browser_actions_bar()->VisibleBrowserActions());
79 }
80 }
81
82 // Test the basic functionality.
83 IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest, Basic) {
84 // Load an extension with no browser action.
85 extension_service()->AddExtension(CreateExtension("alpha", false).get());
86 // This extension should not be in the model (has no browser action).
87 EXPECT_EQ(0, browser_actions_bar()->NumberOfBrowserActions());
88
89 // Load an extension with a browser action.
90 extension_service()->AddExtension(CreateExtension("beta", true).get());
91 EXPECT_EQ(1, browser_actions_bar()->NumberOfBrowserActions());
92 EXPECT_TRUE(browser_actions_bar()->HasIcon(0));
93
94 // Unload the extension.
95 std::string id = browser_actions_bar()->GetExtensionId(0);
96 UnloadExtension(id);
97 EXPECT_EQ(0, browser_actions_bar()->NumberOfBrowserActions());
98 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698