util/test/multiprocess.cc - Issue 640383002: In tests, use ASSERT_NO_FATAL_FAILURE()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/test/multiprocess.cc

Issue 640383002: In tests, use ASSERT_NO_FATAL_FAILURE() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/test/multiprocess.cc

diff --git a/util/test/multiprocess.cc b/util/test/multiprocess.cc

index 795683749405f2c33406156d9d0f83321bf3f644..9a283f39090466e12ddbc4cc9260221a0fb9e928 100644

--- a/util/test/multiprocess.cc

+++ b/util/test/multiprocess.cc

@@ -63,10 +63,7 @@ void Multiprocess::Run() {

scoped_ptr<internal::MultiprocessInfo> info(new internal::MultiprocessInfo);

base::AutoReset<internal::MultiprocessInfo*> reset_info(&info_, info.get());

- PreFork();

- if (testing::Test::HasFatalFailure()) {

- return;

- }

+ ASSERT_NO_FATAL_FAILURE(PreFork());

pid_t pid = fork();

ASSERT_GE(pid, 0) << ErrnoMessage("fork");

« no previous file with comments | « util/test/multiprocess.h ('k') | util/test/multiprocess_exec.cc » ('j') | no next file with comments »